All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Kim Phillips <kim.phillips@amd.com>
Cc: bp@alien8.de, x86@kernel.org, peterz@infradead.org, bp@suse.de,
	bpf@vger.kernel.org, jpoimboe@redhat.com,
	andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org,
	thomas.lendacky@amd.com
Subject: Re: [PATCH v2] x86/bugs: Enable STIBP for IBPB mitigated RetBleed
Date: Sat, 6 Aug 2022 21:00:50 +0200	[thread overview]
Message-ID: <Yu66YlFzd4VRZq6/@gmail.com> (raw)
In-Reply-To: <20220805215009.498407-1-kim.phillips@amd.com>


* Kim Phillips <kim.phillips@amd.com> wrote:

>  			Speculative Code Execution with Return Instructions)
>  			vulnerability.
>  
> +			AMD-based unret and ibpb mitigations alone do not stop
> +			sibling threads influencing the predictions of other sibling
> +			threads.  For that reason, we use STIBP on processors
> +			that support it, and mitigate SMT on processors that don't.

>  	 * retbleed_select_mitigation(); specifically the STIBP selection is
> -	 * forced for UNRET.
> +	 * forced for UNRET or IBPB.

Nit: could you please capitalize the acronyms & instruction names 
consistently? Human eyesight is case sensitive.

Ie. it should be UNRET and IBPB everywhere.

Thanks,

	Ingo

  reply	other threads:[~2022-08-06 19:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 19:22 [PATCH] x86/bugs: Enable STIBP for IBPB mitigated RetBleed Kim Phillips
2022-08-05 14:42 ` Borislav Petkov
2022-08-05 17:04   ` Kim Phillips
2022-08-05 17:55     ` Borislav Petkov
2022-08-05 21:50       ` [PATCH v2] " Kim Phillips
2022-08-06 19:00         ` Ingo Molnar [this message]
2022-08-08 14:17           ` [PATCH v3] " Kim Phillips
2022-08-08 14:23             ` Greg KH
2022-08-08 14:32               ` [PATCH v4] " Kim Phillips
2022-08-08 18:10 ` [tip: x86/urgent] x86/bugs: Enable STIBP for IBPB mitigated RETBleed tip-bot2 for Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yu66YlFzd4VRZq6/@gmail.com \
    --to=mingo@kernel.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=bp@alien8.de \
    --cc=bp@suse.de \
    --cc=bpf@vger.kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.