From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAEA2C00144 for ; Tue, 26 Jul 2022 17:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230214AbiGZRLq (ORCPT ); Tue, 26 Jul 2022 13:11:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbiGZRLp (ORCPT ); Tue, 26 Jul 2022 13:11:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BE3F13E1D; Tue, 26 Jul 2022 10:11:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ACE9DB81893; Tue, 26 Jul 2022 17:11:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D78AFC433D6; Tue, 26 Jul 2022 17:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658855502; bh=oB/9YXDllqHNaPx+0+OoJRyg6nWhXunKlacQATTrCVA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2G3pA4DjMcfYujd4B3AX7B602Rdd3zhyaC9iQ7GgaXEr5kW+nJhEvGMVyt6hZaNhZ +7D8OoWYNOSDLjZyv3aa2UyaqrhLFcPatxkXXvxKtYO9vxb9YLjXJnH//UoYakXv8L 6bjHVWagMvR8rRx11oaI1d6QhGzYWu6f7+95xkyk= Date: Tue, 26 Jul 2022 19:11:39 +0200 From: Greg KH To: Claudiu Beznea Cc: balbi@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, cristian.birsan@microchip.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] usb: gadget: at91_udc: stop using legacy pm ops Message-ID: References: <20220726095948.1809038-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220726095948.1809038-1-claudiu.beznea@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Jul 26, 2022 at 12:59:47PM +0300, Claudiu Beznea wrote: > Stop using legacy PM ops and switch using dev_pm_ops. That says what you did, but not why you are doing this. Please read the kernel documentation for how to write a good kernel changelog and resubmit. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3724DC00140 for ; Tue, 26 Jul 2022 17:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M2616CizXJO7baMRO8kcQMcy6Mbe0bmJIi9oyzNyzuQ=; b=g4I9vhZS0ZVHa7 z4UQYdWAz46qcwHwN6EIWvBgWbNHebnv+in0A1kZgd90xCcN2zR9raJSQ/ze98qv1fQeHY/eD1h6w rRCmaCIlgXcTfsbC0iWdx8X0gs9ehNGScWqo4L+kR8l72BiDxQvcqUp2pPNKk6D2V8CdvH+SFhnbu zSvIMEW36mC4YzKjU05KJTki0B8QQG5ITswzPJZecs7L2RBr84GQO9SZokeqR4k4kxBDNjXSt7WtH tY00zogaCA3cPADSNEtMzYKD/uez8xoNuer5O0Ylt/+tJxgbq3yq3c5zXdCV8afqyeX4Bapv/3iEZ ysJoSX1soPcCFkzm/pQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGO60-001I5u-BL; Tue, 26 Jul 2022 17:11:48 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGO5x-001I3r-43 for linux-arm-kernel@lists.infradead.org; Tue, 26 Jul 2022 17:11:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 97CC5B81891; Tue, 26 Jul 2022 17:11:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D78AFC433D6; Tue, 26 Jul 2022 17:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658855502; bh=oB/9YXDllqHNaPx+0+OoJRyg6nWhXunKlacQATTrCVA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2G3pA4DjMcfYujd4B3AX7B602Rdd3zhyaC9iQ7GgaXEr5kW+nJhEvGMVyt6hZaNhZ +7D8OoWYNOSDLjZyv3aa2UyaqrhLFcPatxkXXvxKtYO9vxb9YLjXJnH//UoYakXv8L 6bjHVWagMvR8rRx11oaI1d6QhGzYWu6f7+95xkyk= Date: Tue, 26 Jul 2022 19:11:39 +0200 From: Greg KH To: Claudiu Beznea Subject: Re: [PATCH 1/2] usb: gadget: at91_udc: stop using legacy pm ops Message-ID: References: <20220726095948.1809038-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220726095948.1809038-1-claudiu.beznea@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_101145_324720_EAEA9231 X-CRM114-Status: UNSURE ( 9.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, alexandre.belloni@bootlin.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, cristian.birsan@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 26, 2022 at 12:59:47PM +0300, Claudiu Beznea wrote: > Stop using legacy PM ops and switch using dev_pm_ops. That says what you did, but not why you are doing this. Please read the kernel documentation for how to write a good kernel changelog and resubmit. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel