From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrey Strachuk <strochuk@ispras.ru>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] staging: rtl8723bs: remove useless comparison in _rtw_reg_apply_flags()
Date: Wed, 27 Jul 2022 08:41:00 +0200 [thread overview]
Message-ID: <YuDd/K5LSj1035pw@kroah.com> (raw)
In-Reply-To: <20220719155309.463286-1-strochuk@ispras.ru>
On Tue, Jul 19, 2022 at 06:53:09PM +0300, Andrey Strachuk wrote:
> Local variable 'ch' is initialized by an address
> of field of ieee80211_supported_band structure, so it does
> not make sense to compare 'ch' with NULL.
Where is it initialized with an address? You need to document this
here.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Strachuk <strochuk@ispras.ru>
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
This is not a bug fix, but a code optimization, so no need for this
Fixes: tag.
thanks,
greg k-h
prev parent reply other threads:[~2022-07-27 6:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 15:53 [PATCH] staging: rtl8723bs: remove useless comparison in _rtw_reg_apply_flags() Andrey Strachuk
2022-07-27 6:41 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuDd/K5LSj1035pw@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=strochuk@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.