From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: r8188eu: get da from ieee80211_mgmt
Date: Wed, 27 Jul 2022 08:43:47 +0200 [thread overview]
Message-ID: <YuDeo4qHOqDkdZy9@kroah.com> (raw)
In-Reply-To: <20220724153917.138848-2-martin@kaiser.cx>
On Sun, Jul 24, 2022 at 05:39:13PM +0200, Martin Kaiser wrote:
> Define a struct ieee80211_mgmt in the OnAssocRsp function. Read the
> destination address (da) from this struct.
This explains (sortta) what this patch does, but not why you are doing
this.
To me this looks like a step backwards, why is this change needed at
all?
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-27 6:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 15:39 [PATCH 0/5] staging: r8188eu: use struct ieee80211_mgmt in OnAssocRsp Martin Kaiser
2022-07-24 15:39 ` [PATCH 1/5] staging: r8188eu: get da from ieee80211_mgmt Martin Kaiser
2022-07-27 6:43 ` Greg Kroah-Hartman [this message]
2022-07-28 5:25 ` Martin Kaiser
2022-07-28 6:58 ` Greg Kroah-Hartman
2022-07-24 15:39 ` [PATCH 2/5] staging: r8188eu: read status_code from struct ieee80211_mgmt Martin Kaiser
2022-07-24 15:39 ` [PATCH 3/5] staging: r8188eu: read capability info " Martin Kaiser
2022-07-24 15:39 ` [PATCH 4/5] staging: r8188eu: read aid " Martin Kaiser
2022-07-24 15:39 ` [PATCH 5/5] staging: r8188eu: use offsetof for ie start offset Martin Kaiser
2022-07-24 18:32 ` [PATCH 0/5] staging: r8188eu: use struct ieee80211_mgmt in OnAssocRsp Philipp Hortmann
2022-08-06 11:13 ` [PATCH v2 " Martin Kaiser
2022-08-06 11:13 ` [PATCH v2 1/5] staging: r8188eu: replace a get_da call Martin Kaiser
2022-08-06 11:13 ` [PATCH v2 2/5] staging: r8188eu: read status_code from struct ieee80211_mgmt Martin Kaiser
2022-08-06 11:13 ` [PATCH v2 3/5] staging: r8188eu: read capability info " Martin Kaiser
2022-08-06 11:13 ` [PATCH v2 4/5] staging: r8188eu: read aid " Martin Kaiser
2022-08-06 11:13 ` [PATCH v2 5/5] staging: r8188eu: simplify the calculation of ie start offset Martin Kaiser
2022-08-06 20:52 ` [PATCH v2 0/5] staging: r8188eu: use struct ieee80211_mgmt in OnAssocRsp Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuDeo4qHOqDkdZy9@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.