From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: vt6655: Rename MACvClearStckDS
Date: Wed, 27 Jul 2022 08:48:14 +0200 [thread overview]
Message-ID: <YuDfrsZeglr1+y7n@kroah.com> (raw)
In-Reply-To: <3bdaf8401f49276c3176d073c7f77da57d7c1e70.1658333350.git.philipp.g.hortmann@gmail.com>
On Wed, Jul 20, 2022 at 06:24:36PM +0200, Philipp Hortmann wrote:
> Fix name of a macro that uses CamelCase which is not
> accepted by checkpatch.pl
You do have 72 columns to use here, feel free to do so :)
Also a bit better description would be nice.
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-27 6:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 16:24 [PATCH 0/3] staging: vt6655: Convert multiline macro to static function Philipp Hortmann
2022-07-20 16:24 ` [PATCH 1/3] staging: vt6655: Rename byOrgValue to reg_value in a macro Philipp Hortmann
2022-07-27 6:47 ` Greg Kroah-Hartman
2022-07-27 15:54 ` Philipp Hortmann
2022-07-27 16:06 ` Greg Kroah-Hartman
2022-07-20 16:24 ` [PATCH 2/3] staging: vt6655: Rename MACvClearStckDS Philipp Hortmann
2022-07-27 6:48 ` Greg Kroah-Hartman [this message]
2022-07-20 16:24 ` [PATCH 3/3] staging: vt6655: Convert macro vt6655_mac_clear_stck_ds to function Philipp Hortmann
2022-07-27 6:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuDfrsZeglr1+y7n@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.