All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: surenb@google.com, mingo@redhat.com, peterz@infradead.org,
	tj@kernel.org, corbet@lwn.net, akpm@linux-foundation.org,
	rdunlap@infradead.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, songmuchun@bytedance.com,
	cgroups@vger.kernel.org
Subject: Re: [PATCH 9/9] sched/psi: add PSI_IRQ to track IRQ/SOFTIRQ pressure
Date: Wed, 27 Jul 2022 09:00:27 -0400	[thread overview]
Message-ID: <YuE26+jMjnE4GZZ2@cmpxchg.org> (raw)
In-Reply-To: <5f91e194-439a-12c0-4987-5dea0e68a60a@bytedance.com>

On Wed, Jul 27, 2022 at 07:28:37PM +0800, Chengming Zhou wrote:
> On 2022/7/26 02:26, Johannes Weiner wrote:
> > I think we can remove the NR_CPU task count, which frees up one
> > u32. Something like the below diff should work (untested!)
> 
> Hi, I tested ok, would you mind if I put this patch in this series?
> 
> Subject: [PATCH] sched/psi: remove NR_ONCPU task accounting
> 
> We put all fields updated by the scheduler in the first cacheline of
> struct psi_group_cpu for performance.
> 
> Since we want add another PSI_IRQ_FULL to track IRQ/SOFTIRQ pressure,
> we need to reclaim space first. This patch remove NR_ONCPU task accounting
> in struct psi_group_cpu, use TSK_ONCPU in state_mask to track instead.

Thanks for testing it, that sounds good.

> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Reviewed-by: Chengming Zhou <zhouchengming@bytedance.com>
> Tested-by: Chengming Zhou <zhouchengming@bytedance.com>

Since you're handling the patch, you need to add your own
Signed-off-by: as well. And keep From: Johannes (git commit --author).

Thanks!

  reply	other threads:[~2022-07-27 13:00 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21  4:04 [PATCH 0/9] sched/psi: some optimization and extension Chengming Zhou
     [not found] ` <20220721040439.2651-1-zhouchengming-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2022-07-21  4:04   ` [PATCH 1/9] sched/psi: fix periodic aggregation shut off Chengming Zhou
2022-07-21  4:04     ` Chengming Zhou
2022-07-25 15:34     ` Johannes Weiner
     [not found]     ` <20220721040439.2651-2-zhouchengming-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2022-07-25 15:39       ` Johannes Weiner
2022-07-25 15:39         ` Johannes Weiner
2022-07-26 13:28         ` Chengming Zhou
2022-07-21  4:04   ` [PATCH 2/9] sched/psi: optimize task switch inside shared cgroups again Chengming Zhou
2022-07-21  4:04     ` Chengming Zhou
2022-07-21  4:04   ` [PATCH 3/9] sched/psi: move private helpers to sched/stats.h Chengming Zhou
2022-07-21  4:04     ` Chengming Zhou
2022-07-25 16:39     ` Johannes Weiner
2022-07-21  4:04   ` [PATCH 4/9] sched/psi: don't change task psi_flags when migrate CPU/group Chengming Zhou
2022-07-21  4:04     ` Chengming Zhou
2022-07-21  4:04   ` [PATCH 7/9] sched/psi: cache parent psi_group to speed up groups iterate Chengming Zhou
2022-07-21  4:04     ` Chengming Zhou
2022-07-21  4:04   ` [PATCH 8/9] sched/psi: add kernel cmdline parameter psi_inner_cgroup Chengming Zhou
2022-07-21  4:04     ` Chengming Zhou
     [not found]     ` <20220721040439.2651-9-zhouchengming-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2022-07-25 16:52       ` Johannes Weiner
2022-07-25 16:52         ` Johannes Weiner
     [not found]         ` <Yt7KQc0nnOypB2b2-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-07-26 13:38           ` [External] " Chengming Zhou
2022-07-26 13:38             ` Chengming Zhou
2022-07-26 17:54         ` Tejun Heo
     [not found]           ` <YuAqWprKd6NsWs7C-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-08-03 12:17             ` Chengming Zhou
2022-08-03 12:17               ` Chengming Zhou
2022-08-03 17:58               ` Tejun Heo
2022-08-03 19:22                 ` Johannes Weiner
2022-08-03 19:48                   ` Tejun Heo
2022-08-04 13:51                   ` Chengming Zhou
     [not found]                     ` <f8444db4-3235-d108-698a-6772e03a6b67-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2022-08-04 16:56                       ` Johannes Weiner
2022-08-04 16:56                         ` Johannes Weiner
2022-08-04  2:02                 ` Chengming Zhou
2022-07-21  4:04 ` [PATCH 5/9] sched/psi: don't create cgroup PSI files when psi_disabled Chengming Zhou
     [not found]   ` <20220721040439.2651-6-zhouchengming-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2022-07-25 16:41     ` Johannes Weiner
2022-07-25 16:41       ` Johannes Weiner
2022-07-21  4:04 ` [PATCH 6/9] sched/psi: save percpu memory when !psi_cgroups_enabled Chengming Zhou
2022-07-25 16:47   ` Johannes Weiner
2022-07-21  4:04 ` [PATCH 9/9] sched/psi: add PSI_IRQ to track IRQ/SOFTIRQ pressure Chengming Zhou
     [not found]   ` <20220721040439.2651-10-zhouchengming-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2022-07-21 10:00     ` kernel test robot
2022-07-21 10:00       ` kernel test robot
2022-07-21 22:10     ` kernel test robot
2022-07-21 22:10       ` kernel test robot
2022-07-22  3:30     ` Abel Wu
2022-07-22  3:30       ` Abel Wu
     [not found]       ` <65d9f79b-be9b-e21e-0624-5c9f2cc0c0b2-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2022-07-22  6:13         ` Chengming Zhou
2022-07-22  6:13           ` Chengming Zhou
2022-07-22  7:14           ` Abel Wu
     [not found]             ` <5e5d41e2-5f89-8c52-11e5-0c55c5595a88-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2022-07-22  7:33               ` Chengming Zhou
2022-07-22  7:33                 ` Chengming Zhou
2022-07-27 16:07     ` Peter Zijlstra
2022-07-27 16:07       ` Peter Zijlstra
2022-07-25 18:26   ` Johannes Weiner
2022-07-26 13:55     ` [External] " Chengming Zhou
2022-07-27 11:28     ` Chengming Zhou
2022-07-27 13:00       ` Johannes Weiner [this message]
2022-07-27 15:09         ` Chengming Zhou
  -- strict thread matches above, loose matches on Subject: below --
2022-07-25  1:41 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuE26+jMjnE4GZZ2@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=songmuchun@bytedance.com \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.