From: Johan Hovold <johan@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Johan Hovold" <johan+linaro@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Stanimir Varbanov" <svarbanov@mm-sol.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Konrad Dybcio" <konrad.dybcio@somainline.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH v2] PCI: qcom: Add support for modular builds
Date: Thu, 28 Jul 2022 14:19:43 +0200 [thread overview]
Message-ID: <YuJ+31mJNHosH5i5@hovoldconsulting.com> (raw)
In-Reply-To: <20220727200257.GA220948@bhelgaas>
On Wed, Jul 27, 2022 at 03:02:57PM -0500, Bjorn Helgaas wrote:
> On Thu, Jul 21, 2022 at 02:35:13PM -0500, Bjorn Helgaas wrote:
> > On Thu, Jul 21, 2022 at 08:47:20AM +0200, Johan Hovold wrote:
> > > Allow the Qualcomm PCIe controller driver to be built as a module, which
> > > is useful for multi-platform kernels as well as during development.
> > >
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> >
> > Applied to pci/ctrl/qcom for v5.20, thanks!
>
> I'm going to drop this one for now, since the module vs remove
> discussion [1] is still ongoing.
>
> This patch actually makes it both *modular* and *removable*. I think
> the modular part is uncontroversial and valuable by itself.
>
> If you want to just make it modular and *non*-removable, I think that
> would be fine and we can add removability next cycle if we think it's
> safe.
>
> [1] https://lore.kernel.org/r/20220721195433.GA1747571@bhelgaas
Nah, I prefer we conclude that discussion so that hopefully this can be
merged as is.
Johan
next prev parent reply other threads:[~2022-07-28 12:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 6:47 [PATCH v2] PCI: qcom: Add support for modular builds Johan Hovold
2022-07-21 19:35 ` Bjorn Helgaas
2022-07-27 20:02 ` Bjorn Helgaas
2022-07-28 12:19 ` Johan Hovold [this message]
2022-09-20 8:47 ` Johan Hovold
2022-09-20 13:37 ` Bjorn Helgaas
2022-09-20 14:05 ` Johan Hovold
2022-09-20 14:27 ` Manivannan Sadhasivam
2022-09-27 13:28 ` Lorenzo Pieralisi
2022-09-28 6:16 ` Johan Hovold
2022-09-20 10:26 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuJ+31mJNHosH5i5@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=helgaas@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.