From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: guaneryu@gmail.com, zlang@redhat.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH 1/3] xfs/432: fix this test when external devices are in use
Date: Thu, 28 Jul 2022 13:16:28 -0700 [thread overview]
Message-ID: <YuLunHKTHbw1wcvZ@infradead.org> (raw)
In-Reply-To: <165903223512.2338516.9583051314883581667.stgit@magnolia>
On Thu, Jul 28, 2022 at 11:17:15AM -0700, Darrick J. Wong wrote:
> +SCRATCH_DEV=$metadump_img _scratch_xfs_repair -n &>> $seqres.full || \
> + echo "xfs_repair on restored fs returned $?"
Wouldn;t it make more sense to have a version of _scratch_xfs_repair
rather than doing a somewhat unexpected override of this global
variable?
next prev parent reply other threads:[~2022-07-28 20:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 18:17 [PATCHSET v2 0/3] fstests: random fixes for v2022.07.24 Darrick J. Wong
2022-07-28 18:17 ` [PATCH 1/3] xfs/432: fix this test when external devices are in use Darrick J. Wong
2022-07-28 20:16 ` Christoph Hellwig [this message]
2022-07-31 5:29 ` Zorro Lang
2022-07-31 16:58 ` Darrick J. Wong
2022-08-01 17:14 ` Christoph Hellwig
2022-08-01 17:43 ` Darrick J. Wong
2022-07-28 18:17 ` [PATCH 2/3] xfs/291: convert open-coded _scratch_xfs_repair usage Darrick J. Wong
2022-07-28 18:17 ` [PATCH 3/3] seek_sanity_test: use XFS ioctls to determine file allocation unit size Darrick J. Wong
2022-07-31 14:11 ` Zorro Lang
-- strict thread matches above, loose matches on Subject: below --
2022-08-03 4:21 [PATCHSET 0/3] fstests: random fixes for v2022.07.31 Darrick J. Wong
2022-08-03 4:21 ` [PATCH 1/3] xfs/432: fix this test when external devices are in use Darrick J. Wong
2022-08-04 15:55 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuLunHKTHbw1wcvZ@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.