From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF7EC04A68 for ; Thu, 28 Jul 2022 22:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231854AbiG1WLZ (ORCPT ); Thu, 28 Jul 2022 18:11:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231630AbiG1WLX (ORCPT ); Thu, 28 Jul 2022 18:11:23 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED1EC78DC6 for ; Thu, 28 Jul 2022 15:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=LDqyog/eub7xSOGb/4JZwbkZ2yQA+0FvA48Dk0Q+fD4=; b=ASaiF4de4ElG33bKs8Ke3YvK3q pkzC6eoCCPWBCAeOOFxWe22W21ckIA/Z1PxTJG6wX8Uu0PFco3Hnu8MZ1vv+3YSO8EL2tykNE5Q+c kdScrLnqy3IZ5efodDVr7aNmFaBeHSvdUJw6T2lEmho0Wy0N22aweizhLhNu2+2hTOH8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oHBiu-00BqbI-Be; Fri, 29 Jul 2022 00:11:16 +0200 Date: Fri, 29 Jul 2022 00:11:16 +0200 From: Andrew Lunn To: Oliver Neukum Cc: hayeswang@realtek.com, netdev@vger.kernel.org Subject: Re: [RFC] r8152: pass through needs to be singular Message-ID: References: <20220728191851.30402-1-oneukum@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220728191851.30402-1-oneukum@suse.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jul 28, 2022 at 09:18:51PM +0200, Oliver Neukum wrote: > If multiple devices are connected only one of them > is allowed to get the pass through MAC Is that true? Ethernet switches often use the same MAC address on multiple ports. It is not inherently broken to have the same MAC address on multiple interfaces. We also need to watch out for regressions. There could be users who do have the same MAC address on multiple interfaces, and it works for them. With this change it is a 50/50 chance they no longer get the MAC address they expect, depending on probe order. We know this implementation of pass through it very broken, but unfortunately, it is there, and we have to follow the normal regression rules, even if we really would like to throw it all out. What exactly is your problem which you are trying to fix? Andrew