From: Jason Gunthorpe <jgg@nvidia.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: Matthew Rosato <mjrosato@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Nicolin Chen <nicolinc@nvidia.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v3 1/3] vfio/ccw: Add length to DMA_UNMAP checks
Date: Fri, 29 Jul 2022 16:13:32 -0300 [thread overview]
Message-ID: <YuQxXEWYoY23GiCv@nvidia.com> (raw)
In-Reply-To: <20220728204914.2420989-2-farman@linux.ibm.com>
On Thu, Jul 28, 2022 at 10:49:12PM +0200, Eric Farman wrote:
> As pointed out with the simplification of the
> VFIO_IOMMU_NOTIFY_DMA_UNMAP notifier [1], the length
> parameter was never used to check against the pinned
> pages.
>
> Let's correct that, and see if a page is within the
> affected range instead of simply the first page of
> the range.
>
> [1] https://lore.kernel.org/kvm/20220720170457.39cda0d0.alex.williamson@redhat.com/
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_cp.c | 16 +++++++++++-----
> drivers/s390/cio/vfio_ccw_cp.h | 2 +-
> drivers/s390/cio/vfio_ccw_ops.c | 2 +-
> 3 files changed, 13 insertions(+), 7 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2022-07-29 19:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 20:49 [PATCH v3 0/3] vfio-ccw fixes for 5.20 Eric Farman
2022-07-28 20:49 ` [PATCH v3 1/3] vfio/ccw: Add length to DMA_UNMAP checks Eric Farman
2022-07-29 19:13 ` Jason Gunthorpe [this message]
2022-07-28 20:49 ` [PATCH v3 2/3] vfio/ccw: Remove FSM Close from remove handlers Eric Farman
2022-07-29 19:18 ` Jason Gunthorpe
2022-07-28 20:49 ` [PATCH v3 3/3] vfio/ccw: Check return code from subchannel quiesce Eric Farman
2022-07-29 19:21 ` Jason Gunthorpe
2022-08-01 20:55 ` [PATCH v3 0/3] vfio-ccw fixes for 5.20 Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuQxXEWYoY23GiCv@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.