From: Rebecca Mckeever <remckee0@gmail.com>
To: shaoqin.huang@intel.com
Cc: rppt@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] memblock test: Modify the obsolete description in README
Date: Fri, 29 Jul 2022 17:03:21 -0500 [thread overview]
Message-ID: <YuRZKTNl+USWFR5H@bertie> (raw)
In-Reply-To: <20220729161125.190845-1-shaoqin.huang@intel.com>
On Fri, Jul 29, 2022 at 10:11:25AM -0600, shaoqin.huang@intel.com wrote:
> From: Shaoqin Huang <shaoqin.huang@intel.com>
>
> The VERBOSE option in Makefile has been moved, but there still have the
> description left in README. For now, we use `-v` options when running
> memblock test to print information, so using the new to replace the
> obsolete items.
>
> Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
> ---
> Changelog:
> ----------
> v3:
> - Using `build options` replace `options` to make it more clear.
> v2:
> - Tweak the sentence to make it more clear and continuesly.
> - Commit log changes.
>
Looks good!
Acked-by: Rebecca Mckeever <remckee0@gmail.com>
> tools/testing/memblock/README | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/memblock/README b/tools/testing/memblock/README
> index 058146b528a5..72162b5f4a76 100644
> --- a/tools/testing/memblock/README
> +++ b/tools/testing/memblock/README
> @@ -33,20 +33,23 @@ To run the tests, build the main target and run it:
>
> $ make && ./main
>
> -A successful run produces no output. It is also possible to override different
> -configuration parameters. For example, to include verbose output, specify the
> -VERBOSE flag when building the main target:
> +A successful run produces no output. It is possible to control the behavior
> +by passing options from command line. For example, to include verbose output,
> +append the `-v` options when you run the tests:
>
> -$ make VERBOSE=1
> +$ ./main -v
>
> This will print information about which functions are being tested and the
> number of test cases that passed.
>
> -To simulate enabled NUMA, use:
> +For the full list of options from command line, see `./main --help`.
> +
> +It is also possible to override different configuration parameters to change it
> +test functions. For example, To simulate enabled NUMA, use:
>
> $ make NUMA=1
>
> -For the full list of options, see `make help`.
> +For the full list of build options, see `make help`.
>
> Project structure
> =================
> --
> 2.30.2
>
>
Thanks,
Rebecca
next prev parent reply other threads:[~2022-07-29 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 16:11 [PATCH v3] memblock test: Modify the obsolete description in README shaoqin.huang
2022-07-29 22:03 ` Rebecca Mckeever [this message]
2022-07-30 8:47 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuRZKTNl+USWFR5H@bertie \
--to=remckee0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=shaoqin.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.