From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Song Liu <songliubraving@fb.com>,
Blake Jones <blakejones@google.com>
Subject: Re: [PATCH 2/3] perf lock: Add -m/--map-length option
Date: Tue, 2 Aug 2022 15:17:05 -0300 [thread overview]
Message-ID: <YulqIWpDMisldmHH@kernel.org> (raw)
In-Reply-To: <CAM9d7chZT-mociK=+iF_6SO=1JuD2xaL1HpE4eeo=myngq9vTw@mail.gmail.com>
Em Tue, Aug 02, 2022 at 11:05:09AM -0700, Namhyung Kim escreveu:
> On Tue, Aug 2, 2022 at 10:43 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Em Tue, Aug 02, 2022 at 12:35:10AM -0700, Namhyung Kim escreveu:
> > > +-m::
> > > +--map-length::
> > > + Maximum number of BPF map entries (default: 10240).
> >
> > --map-nr-entries?
> >
> > I think we use this jargon "nr-entries" for arrays, lists, etc, better
> > try to stick to it.
> Makes sense, will change.
Great.
> > Also what do you think about not using single letter options for things
> > that are not that used?
> >
> > The map size has a default, one that seems generous, so changing it
> > should be something uncommon, and then, if it becomes common that more
> > entries are needed by default, we can change the default in the tool.
>
> Fair enough, I'll remove the single letter option.
Thanks!
- Arnaldo
next prev parent reply other threads:[~2022-08-02 18:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 7:35 [PATCH 1/3] perf lock: Introduce struct lock_contention Namhyung Kim
2022-08-02 7:35 ` [PATCH 2/3] perf lock: Add -m/--map-length option Namhyung Kim
2022-08-02 17:43 ` Arnaldo Carvalho de Melo
2022-08-02 18:05 ` Namhyung Kim
2022-08-02 18:17 ` Arnaldo Carvalho de Melo [this message]
2022-08-02 7:35 ` [PATCH 3/3] perf lock: Print lost entries at the end Namhyung Kim
2022-08-02 17:45 ` Arnaldo Carvalho de Melo
2022-08-02 18:08 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YulqIWpDMisldmHH@kernel.org \
--to=acme@kernel.org \
--cc=blakejones@google.com \
--cc=boqun.feng@gmail.com \
--cc=dave@stgolabs.net \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.