From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Rajat Khandelwal <rajat.khandelwal@intel.com>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, pmalani@google.com,
bleung@google.com
Subject: Re: [PATCH] Supporting wake on DP hot events behind TBT/USB4 routers
Date: Wed, 3 Aug 2022 08:36:49 +0300 [thread overview]
Message-ID: <YuoJceCfuJ4RKon5@lahna> (raw)
In-Reply-To: <20220803010139.GA32634@rajth-NUC10i7FNH>
Hi,
On Wed, Aug 03, 2022 at 06:31:39AM +0530, Rajat Khandelwal wrote:
> Current implementation doesn't allow user to go into system suspend
> and simultaneously project the screen on an external display connected
> to a TBT/USB4 device. This patch enables this feature.
>
> Let me know what you think about this.
Please prefix patches to follow the sybsystem style. For Thunderbolt it
should be "thunderbolt: ....".
This will cause any monitor plug to wake up the system and I'm not sure
we want that, at least to be default behaviour. If you have a regular
Type-C (non-USB4/TBT) dock and you plug in a monitor to that, does it
wake up?
IIRC I already suggested you to do this for the USB4 ports themselves
(struct usb4_port) so that userspace can make them wake up the system on
any event by writing "enabled > .../wakeup" which is the normal way.
next parent reply other threads:[~2022-08-03 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220803010139.GA32634@rajth-NUC10i7FNH>
2022-08-03 5:36 ` Mika Westerberg [this message]
2022-08-03 15:15 ` [PATCH] Supporting wake on DP hot events behind TBT/USB4 routers Benson Leung
2022-08-03 15:57 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuoJceCfuJ4RKon5@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=bleung@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=pmalani@google.com \
--cc=rajat.khandelwal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.