All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "Andreas Färber" <afaerber@suse.de>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Christian Hewitt" <christianshewitt@gmail.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: bitbang: Fix lsb-first Rx
Date: Wed, 3 Aug 2022 17:33:48 +0100	[thread overview]
Message-ID: <YuqjbFy3f0EtsokI@sirena.org.uk> (raw)
In-Reply-To: <ae7e7d7b-bf90-7f23-8a27-e6358b3ff4f6@arm.com>

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

On Wed, Aug 03, 2022 at 04:22:13PM +0100, Robin Murphy wrote:
> On 2022-08-03 16:02, Mark Brown wrote:

> > So if this never worked we presumably have some systems out there which
> > somehow rely on the old behaviour that we need to fix somehow - copying

> Hmm, I can't imagine anyone's relying too critically on data transfer
> corruption :/

Unless it happens to get corrupted into what is actually wanted - it
wouldn't be the first time I've seen driver code bodge around some issue
in the core.  Doesn't seem super likely here given the nature of the bug
but it's alway worth checking.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-08-03 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 14:58 [PATCH] spi: bitbang: Fix lsb-first Rx Robin Murphy
2022-08-03 15:02 ` Mark Brown
2022-08-03 15:22   ` Robin Murphy
2022-08-03 16:33     ` Mark Brown [this message]
2022-08-15 15:58 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuqjbFy3f0EtsokI@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=afaerber@suse.de \
    --cc=christianshewitt@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.