From: Oliver Upton <oliver.upton@linux.dev>
To: Mingwei Zhang <mizhang@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] selftests: KVM/x86: Fix vcpu_{save,load}_state() by adding APIC state into kvm_x86_state
Date: Wed, 3 Aug 2022 18:44:51 +0000 [thread overview]
Message-ID: <YurCI5PQu44UJ0a7@google.com> (raw)
In-Reply-To: <20220802230718.1891356-3-mizhang@google.com>
Hi Mingwei,
On Tue, Aug 02, 2022 at 11:07:15PM +0000, Mingwei Zhang wrote:
> Fix vcpu_{save,load}_state() by adding APIC state into kvm_x86_state and
> properly save/restore it in vcpu_{save,load}_state(). When vcpu resets,
> APIC state become software disabled in kernel and thus the corresponding
> vCPU is not able to receive posted interrupts [1]. So, add APIC
> save/restore in userspace in selftest library code.
Of course, there are no hard rules around it but IMO a changelog is
easier to grok if it first describes the what/why of the problem, then
afterwards how it is fixed by the commit.
> [1] commit 97222cc83163 ("KVM: Emulate local APIC in kernel").
What is the reason for the citation here?
> Cc: Jim Mattson <jmattson@google.com>
>
nit: no newline between footers.
> Signed-off-by: Mingwei Zhang <mizhang@google.com>
--
Thanks,
Oliver
next prev parent reply other threads:[~2022-08-03 18:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 23:07 [PATCH 0/5] Fix a race between posted interrupt delivery and migration in a nested VM Mingwei Zhang
2022-08-02 23:07 ` [PATCH 1/5] KVM: x86: Get vmcs12 pages before checking pending interrupts Mingwei Zhang
2022-08-03 10:08 ` Maxim Levitsky
2022-08-03 16:45 ` Mingwei Zhang
2022-08-03 17:00 ` Mingwei Zhang
2022-08-03 18:36 ` Oliver Upton
2022-08-03 17:18 ` Paolo Bonzini
2022-08-03 17:51 ` Mingwei Zhang
2022-08-03 19:34 ` Maxim Levitsky
2022-08-25 0:11 ` Sean Christopherson
2022-08-25 2:51 ` Jim Mattson
2022-08-25 14:40 ` Sean Christopherson
2022-08-25 17:16 ` Mingwei Zhang
2022-08-25 17:53 ` Sean Christopherson
2022-08-25 20:35 ` Mingwei Zhang
2022-08-25 20:37 ` Mingwei Zhang
2022-08-25 23:21 ` Jim Mattson
2022-08-02 23:07 ` [PATCH 2/5] selftests: KVM/x86: Fix vcpu_{save,load}_state() by adding APIC state into kvm_x86_state Mingwei Zhang
2022-08-03 18:44 ` Oliver Upton [this message]
2022-08-03 19:21 ` Sean Christopherson
2022-08-03 23:55 ` Oliver Upton
2022-08-02 23:07 ` [PATCH 3/5] selftests: KVM: Introduce vcpu_run_interruptable() Mingwei Zhang
2022-08-25 0:15 ` Sean Christopherson
2022-08-28 19:21 ` Mingwei Zhang
2022-08-02 23:07 ` [PATCH 4/5] selftests: KVM: Add support for posted interrupt handling in L2 Mingwei Zhang
2022-08-25 0:16 ` Sean Christopherson
2022-08-28 19:29 ` Mingwei Zhang
2022-08-02 23:07 ` [PATCH 5/5] selftests: KVM: Test if posted interrupt delivery race with migration Mingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YurCI5PQu44UJ0a7@google.com \
--to=oliver.upton@linux.dev \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mizhang@google.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.