All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Bharata B Rao <bharata@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	mingo@redhat.com, x86@kernel.org, dave.hansen@linux.intel.com,
	nikunj@amd.com, hpa@zytor.com, Abraham.Shaju@amd.com
Subject: Re: [RFC FIX PATCH] x86/e820: Stop kernel boot when RAM resource reservation fails
Date: Thu, 4 Aug 2022 11:46:35 +0200	[thread overview]
Message-ID: <YuuVezQMK/ytzMTe@gmail.com> (raw)
In-Reply-To: <24ccd22f-6708-3265-4012-66f01108ff22@amd.com>


* Bharata B Rao <bharata@amd.com> wrote:

> On 7/18/2022 8:37 PM, Borislav Petkov wrote:
> > 
> > I betcha you can generate a lot of "kernel bugs" with weird qemu
> > options. If it is not a real use case, nobody cares.
> 
> I see that we will hit this problem by default when starting
> a guest with 1T or more memory using QEMU.
> 
> > 
> > And even if it were a real use case, panicking the machine is not the
> > right fix.
> 
> I couldn't see a clean exit/recovery option in 
> setup_arch()->e820__reserve_resources() where this happens. Any 
> suggestions?

I'd emit a low impact, non-fatal WARN()ing to make sure users aren't silent 
victims of an easily detectable firmware (Qemu) misconfiguration.

Thanks,

	Ingo

      parent reply	other threads:[~2022-08-04  9:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18  8:58 [RFC FIX PATCH] x86/e820: Stop kernel boot when RAM resource reservation fails Bharata B Rao
2022-07-18 10:42 ` Boris Petkov
2022-07-18 14:54   ` Bharata B Rao
2022-07-18 15:07     ` Borislav Petkov
2022-07-19  4:15       ` Bharata B Rao
2022-07-19 17:12         ` Sean Christopherson
2022-08-04  9:46         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuuVezQMK/ytzMTe@gmail.com \
    --to=mingo@kernel.org \
    --cc=Abraham.Shaju@amd.com \
    --cc=bharata@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nikunj@amd.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.