From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25129C19F2A for ; Thu, 4 Aug 2022 15:00:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9740AF3; Thu, 4 Aug 2022 16:59:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9740AF3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1659625236; bh=MG/OLbjvUhmhCpOzmNodao8upPyMUSDGDlCf4g1Eh8w=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JoMYqdrFz4B96i1PfCmnwjHYVHj3YVZECwaCVcIqzIB0BNz7bR6fgp3k6T23fmCDN 34Lz3l6IPBTQLDQieUEB/ip4T7I/g3nlhUck66tcSXYS+0K+xEg7vMyVRcNf7b2yGa Vm1ctdpPAFQon1LfzHhhXQB3m5AvErrunga1dnpk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3AFA9F8012F; Thu, 4 Aug 2022 16:59:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8E33EF8016A; Thu, 4 Aug 2022 16:59:44 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6C3ABF8012F; Thu, 4 Aug 2022 16:59:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6C3ABF8012F Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c0CgKr7e" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5EC0560DF4; Thu, 4 Aug 2022 14:59:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA3F7C433C1; Thu, 4 Aug 2022 14:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659625172; bh=MG/OLbjvUhmhCpOzmNodao8upPyMUSDGDlCf4g1Eh8w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c0CgKr7ehUtGuS3wp8y8m8OtWbhfEOxk49tcM/MH4FlGcXmpiu6UyWwDl9JQLoS8U HNGhEvCTp4Ux90AuEx9zSWQLTkXTo5P1EZL9RJEUbFELp6pjuIqPjvieYGGJ3EMXi8 jGO+iVCvN14kxXkFuuorjPcXDUUzlo0LHgWvcybGLswb4Ie/FstY+nsdybl8IxPPpz tkxl53aibDN5URDHncyDCfT3sVlxslwrQXBOZx99tGeH5lY7fu4KFi7ts5522MIV7X htz2sr7xYv82aOqR8tmW7XQDtQC4EdRb/h1Q6XqW8RcSo8PlevvXVrTQZ9j59UJ+Mk vE5znSwjnW5mw== Date: Thu, 4 Aug 2022 15:59:26 +0100 From: Mark Brown To: "chunxu.li" Subject: Re: [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select Message-ID: References: <20220804091359.31449-1-chunxu.li@mediatek.com> <20220804091359.31449-2-chunxu.li@mediatek.com> <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h0hDaRGCHYmaxJ2S" Content-Disposition: inline In-Reply-To: <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com> X-Cookie: Did I say 2? I lied. Cc: alsa-devel@alsa-project.org, peter.ujfalusi@linux.intel.com, tinghan.shen@mediatek.com, pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com, project_global_chrome_upstream_group@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, yc.hung@mediatek.com, matthias.bgg@gmail.com, sound-open-firmware@alsa-project.org, daniel.baluta@nxp.com, linux-kernel@vger.kernel.org, angelogioacchino.delregno@collabora.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --h0hDaRGCHYmaxJ2S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 04, 2022 at 10:36:07PM +0800, chunxu.li wrote: > Thanks for you advice, I'll remove the callback function, and directly > call sof_of_machine_select() in sof_machine_check() as following. >=20 > int sof_machine_check(struct snd_sof_dev *sdev) > { > } >=20 > =09 > + of_mach =3D sof_of_machine_select(sdev); > + if (of_mach) { > + sof_pdata->of_machine =3D of_mach; > + return 0; > + } Looks good. --h0hDaRGCHYmaxJ2S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLr3s0ACgkQJNaLcl1U h9CNtgf/XRsA3q6DYLqEaEXV4tXIlM8fA/R/M0YDmHq6Ue+jq26vdS+Af5jl77wB FIpNpuihB4hPSw02XTLtF7vyGr2FovaTLOCQcYI1YFv/HdKvw2e/F7CGKbopburY DaP2S1j4l5n/cEGFht//jtFMR1wlmgLPcjcSCx62mZpAqvUulCjnjL5EMhyygC2W n+80WJg3AH1EzsDtYEsvjs7xI7zswHcamarrPa3Wgl/FIiAS99nk1PH17AKIlncB Gl/wOsK9p5nDKqiKGrLmVuC80G6DOC2NcvMmu+zgElXU6SmUsytHQQWuWxfJ9jpr PQ16skJvJ9CihoHwi7dYaA8P6h3J5Q== =uDFa -----END PGP SIGNATURE----- --h0hDaRGCHYmaxJ2S-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10F12C3F6B0 for ; Thu, 4 Aug 2022 14:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LmqUKOO9XNrI/cs1MrOy1b0u4h0VrYYKXIeI6cyXNGY=; b=fUczqP4hN99PTF+pISQiYDVPyI BcX+buXQItgghp1b+AZrckLljR2vwKzB/lppihEIexLS0Ky5tJ0TotMsdqVVsfVLyo3M+oeNfIOs9 AkQQkIedcZqV0n0tnb+UeVzqjI4gagV2st60qdkchizpRP3IgMuV47/vZrVvArAe8g3pEOfOisOzt 4BrDY7VPZblMKGb5Bq5qrogV6T1IxF/JbzMZ3tHxLdYcI+9411j6prUCzmSh2OL8E2i2TaCALIJyy nG9vJhsB+Rra/NPukbJeH8osU/1mT6xJnsN3mJsMIPJGwObbDvy5brOP+Ow+Q6MiZB5EKD/mGd41Z nHaZbz3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJcKC-006wPx-2t; Thu, 04 Aug 2022 14:59:48 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJcJy-006wJF-5n; Thu, 04 Aug 2022 14:59:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5EC0560DF4; Thu, 4 Aug 2022 14:59:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA3F7C433C1; Thu, 4 Aug 2022 14:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659625172; bh=MG/OLbjvUhmhCpOzmNodao8upPyMUSDGDlCf4g1Eh8w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c0CgKr7ehUtGuS3wp8y8m8OtWbhfEOxk49tcM/MH4FlGcXmpiu6UyWwDl9JQLoS8U HNGhEvCTp4Ux90AuEx9zSWQLTkXTo5P1EZL9RJEUbFELp6pjuIqPjvieYGGJ3EMXi8 jGO+iVCvN14kxXkFuuorjPcXDUUzlo0LHgWvcybGLswb4Ie/FstY+nsdybl8IxPPpz tkxl53aibDN5URDHncyDCfT3sVlxslwrQXBOZx99tGeH5lY7fu4KFi7ts5522MIV7X htz2sr7xYv82aOqR8tmW7XQDtQC4EdRb/h1Q6XqW8RcSo8PlevvXVrTQZ9j59UJ+Mk vE5znSwjnW5mw== Date: Thu, 4 Aug 2022 15:59:26 +0100 From: Mark Brown To: "chunxu.li" Cc: pierre-louis.bossart@linux.intel.com, peter.ujfalusi@linux.intel.com, lgirdwood@gmail.com, angelogioacchino.delregno@collabora.com, daniel.baluta@nxp.com, matthias.bgg@gmail.com, yc.hung@mediatek.com, tinghan.shen@mediatek.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, sound-open-firmware@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, project_global_chrome_upstream_group@mediatek.com Subject: Re: [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select Message-ID: References: <20220804091359.31449-1-chunxu.li@mediatek.com> <20220804091359.31449-2-chunxu.li@mediatek.com> <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h0hDaRGCHYmaxJ2S" Content-Disposition: inline In-Reply-To: <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com> X-Cookie: Did I say 2? I lied. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220804_075934_334435_992772FD X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --h0hDaRGCHYmaxJ2S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 04, 2022 at 10:36:07PM +0800, chunxu.li wrote: > Thanks for you advice, I'll remove the callback function, and directly > call sof_of_machine_select() in sof_machine_check() as following. >=20 > int sof_machine_check(struct snd_sof_dev *sdev) > { > } >=20 > =09 > + of_mach =3D sof_of_machine_select(sdev); > + if (of_mach) { > + sof_pdata->of_machine =3D of_mach; > + return 0; > + } Looks good. --h0hDaRGCHYmaxJ2S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLr3s0ACgkQJNaLcl1U h9CNtgf/XRsA3q6DYLqEaEXV4tXIlM8fA/R/M0YDmHq6Ue+jq26vdS+Af5jl77wB FIpNpuihB4hPSw02XTLtF7vyGr2FovaTLOCQcYI1YFv/HdKvw2e/F7CGKbopburY DaP2S1j4l5n/cEGFht//jtFMR1wlmgLPcjcSCx62mZpAqvUulCjnjL5EMhyygC2W n+80WJg3AH1EzsDtYEsvjs7xI7zswHcamarrPa3Wgl/FIiAS99nk1PH17AKIlncB Gl/wOsK9p5nDKqiKGrLmVuC80G6DOC2NcvMmu+zgElXU6SmUsytHQQWuWxfJ9jpr PQ16skJvJ9CihoHwi7dYaA8P6h3J5Q== =uDFa -----END PGP SIGNATURE----- --h0hDaRGCHYmaxJ2S-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BCF3C19F2A for ; Thu, 4 Aug 2022 15:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TpE9sbTexRjfsn86G1O1giLFJvJB4fQmP5mzYn3xPIQ=; b=Oe12nQbjgd9ZvqRkGp1+YVnvbt uyZGnlmGpaY9bYxjw11Gwa9XPW/ZwhJAKIGrzbPbIzSPE7P8mut96sAiP8iIpVU7c2OP9PBqSH2ne HAEZvcbEUyw4rAp3fXaQuhOUwpTLcUGQQ7eLwfGomaAUnXg3xyGX57j6rusprKsb9SNg6JYE9jb8M hmjx+xGSPuHw4R2KhHwj1a0zpBPxcWepf/aSOK66iMq5wcDNH1GvWRdvLoDC3ccz5bSdI9mDxohOx sAKsRYBd2IwtiFyDcznsQksBcp8/AfsBzkA8iNY+52gbaaHI3VpzFdqoQfDxqj971q9wSz11OCC5D +aK1JGSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJcK1-006wL0-He; Thu, 04 Aug 2022 14:59:37 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJcJy-006wJF-5n; Thu, 04 Aug 2022 14:59:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5EC0560DF4; Thu, 4 Aug 2022 14:59:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA3F7C433C1; Thu, 4 Aug 2022 14:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659625172; bh=MG/OLbjvUhmhCpOzmNodao8upPyMUSDGDlCf4g1Eh8w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c0CgKr7ehUtGuS3wp8y8m8OtWbhfEOxk49tcM/MH4FlGcXmpiu6UyWwDl9JQLoS8U HNGhEvCTp4Ux90AuEx9zSWQLTkXTo5P1EZL9RJEUbFELp6pjuIqPjvieYGGJ3EMXi8 jGO+iVCvN14kxXkFuuorjPcXDUUzlo0LHgWvcybGLswb4Ie/FstY+nsdybl8IxPPpz tkxl53aibDN5URDHncyDCfT3sVlxslwrQXBOZx99tGeH5lY7fu4KFi7ts5522MIV7X htz2sr7xYv82aOqR8tmW7XQDtQC4EdRb/h1Q6XqW8RcSo8PlevvXVrTQZ9j59UJ+Mk vE5znSwjnW5mw== Date: Thu, 4 Aug 2022 15:59:26 +0100 From: Mark Brown To: "chunxu.li" Cc: pierre-louis.bossart@linux.intel.com, peter.ujfalusi@linux.intel.com, lgirdwood@gmail.com, angelogioacchino.delregno@collabora.com, daniel.baluta@nxp.com, matthias.bgg@gmail.com, yc.hung@mediatek.com, tinghan.shen@mediatek.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, sound-open-firmware@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, project_global_chrome_upstream_group@mediatek.com Subject: Re: [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select Message-ID: References: <20220804091359.31449-1-chunxu.li@mediatek.com> <20220804091359.31449-2-chunxu.li@mediatek.com> <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com> MIME-Version: 1.0 In-Reply-To: <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com> X-Cookie: Did I say 2? I lied. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220804_075934_334435_992772FD X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5120615427258813753==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5120615427258813753== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h0hDaRGCHYmaxJ2S" Content-Disposition: inline --h0hDaRGCHYmaxJ2S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 04, 2022 at 10:36:07PM +0800, chunxu.li wrote: > Thanks for you advice, I'll remove the callback function, and directly > call sof_of_machine_select() in sof_machine_check() as following. >=20 > int sof_machine_check(struct snd_sof_dev *sdev) > { > } >=20 > =09 > + of_mach =3D sof_of_machine_select(sdev); > + if (of_mach) { > + sof_pdata->of_machine =3D of_mach; > + return 0; > + } Looks good. --h0hDaRGCHYmaxJ2S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLr3s0ACgkQJNaLcl1U h9CNtgf/XRsA3q6DYLqEaEXV4tXIlM8fA/R/M0YDmHq6Ue+jq26vdS+Af5jl77wB FIpNpuihB4hPSw02XTLtF7vyGr2FovaTLOCQcYI1YFv/HdKvw2e/F7CGKbopburY DaP2S1j4l5n/cEGFht//jtFMR1wlmgLPcjcSCx62mZpAqvUulCjnjL5EMhyygC2W n+80WJg3AH1EzsDtYEsvjs7xI7zswHcamarrPa3Wgl/FIiAS99nk1PH17AKIlncB Gl/wOsK9p5nDKqiKGrLmVuC80G6DOC2NcvMmu+zgElXU6SmUsytHQQWuWxfJ9jpr PQ16skJvJ9CihoHwi7dYaA8P6h3J5Q== =uDFa -----END PGP SIGNATURE----- --h0hDaRGCHYmaxJ2S-- --===============5120615427258813753== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5120615427258813753==--