From: Sean Christopherson <seanjc@google.com>
To: Aaron Lewis <aaronlewis@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, jmattson@google.com
Subject: Re: [PATCH v3 1/5] kvm: x86/pmu: Introduce masked events to the pmu event filter
Date: Thu, 4 Aug 2022 16:29:36 +0000 [thread overview]
Message-ID: <Yuvz8BbOblFAgDLW@google.com> (raw)
In-Reply-To: <YuvzHkmU2DsBe6Rj@google.com>
On Thu, Aug 04, 2022, Sean Christopherson wrote:
> On Sat, Jul 09, 2022, Aaron Lewis wrote:
> if (entry) {
> pivot = <compute index of found entry>
>
> /*
> * comment about how the key works and wanting to find any
> * matching filter entry.
> */
> for (i = pivot; i > 0; i--) {
> entry = &filter->events[i];
> if (get_event(*entry) != get_event(eventsel)
Just saw Jim's comment about using "key". That would indeed make it easier to
understand what this is doing.
Note, the missing parantheses throughout aren't intentional :-)
next prev parent reply other threads:[~2022-08-04 16:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 1:17 [PATCH v3 0/5] kvm: x86/pmu: Introduce and test masked events Aaron Lewis
2022-07-09 1:17 ` [PATCH v3 1/5] kvm: x86/pmu: Introduce masked events to the pmu event filter Aaron Lewis
2022-08-03 0:19 ` Jim Mattson
2022-08-03 12:28 ` Jim Mattson
2022-08-04 1:36 ` Aaron Lewis
2022-08-04 16:41 ` Jim Mattson
2022-08-04 16:26 ` Sean Christopherson
2022-08-04 16:29 ` Sean Christopherson [this message]
2022-08-11 0:08 ` Aaron Lewis
2022-07-09 1:17 ` [PATCH v3 2/5] selftests: kvm/x86: Add flags when creating a " Aaron Lewis
2022-07-09 1:17 ` [PATCH v3 4/5] selftests: kvm/x86: Add testing for inverted masked events Aaron Lewis
2022-07-09 1:17 ` [PATCH v3 5/5] selftests: kvm/x86: Add testing for KVM_SET_PMU_EVENT_FILTER Aaron Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yuvz8BbOblFAgDLW@google.com \
--to=seanjc@google.com \
--cc=aaronlewis@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.