From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 294DFC25B06 for ; Thu, 4 Aug 2022 20:32:34 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 72B3D3C9482 for ; Thu, 4 Aug 2022 22:32:33 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id CB3853C1BBA for ; Thu, 4 Aug 2022 22:32:21 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 328221401217 for ; Thu, 4 Aug 2022 22:32:20 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6529433BE6; Thu, 4 Aug 2022 20:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1659645135; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pkigYPeUut6TdEoWnglqATIPjSyGsB2WdGd2RXHdTKk=; b=w2v7bNxELECyImcOBGjHlDXBe7Tzl/RgxvkGyDupLGB7M5tG2X1M6leqXz8NWIjZ9vrgvV Iua4Ht8C/1nwjFaDtSxu1vilSL35hRYK+U6GoG6SNExGvEW/LvCrvi3ulS82hZqjJOXq0Y rwxuM8o/oy5KPFdptSul38xiR99KV/0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1659645135; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pkigYPeUut6TdEoWnglqATIPjSyGsB2WdGd2RXHdTKk=; b=RAxZFFWmwcdPZNaR6QtGu1uN7jdbeIGEFNjO0HcHO/4NOhtlny2B6DzNUbDzmKc9B31G87 TLtFmT7atz+1jkCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 30F4413434; Thu, 4 Aug 2022 20:32:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7VYpCs8s7GLVeAAAMHmgww (envelope-from ); Thu, 04 Aug 2022 20:32:15 +0000 Date: Thu, 4 Aug 2022 22:32:12 +0200 From: Petr Vorel To: Martin Doucha Message-ID: References: <1659497063-2212-1-git-send-email-xuyang2018.jy@fujitsu.com> <1659497063-2212-2-git-send-email-xuyang2018.jy@fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 2/2] syscalls/openat: Add new regression test when using open(O_TMPFILE) under umask X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: brauner@kernel.org, ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi all, ... > > +static void open_tmpfile_supported(int dirfd) > > +{ > > + TEST(openat(dirfd, ".", O_TMPFILE | O_RDWR, S_IXGRP | S_ISGID)); > > + > > + if (TST_RET == -1) { > > + if (errno == ENOTSUP) > > + tst_brk(TCONF, "fs doesn't support O_TMPFILE"); > > + else > > + tst_brk(TBROK | TTERRNO, "open(%d, O_TMPFILE) failed", dirfd); > > + } > What if openat() returns some other negative value? How about add ENOTSUP to safe_openat() (lib/tst_safe_file_at.c) and use SAFE_OPENAT() here? Kind regards, Petr > > + > > + SAFE_CLOSE(TST_RET); > > +} ... -- Mailing list info: https://lists.linux.it/listinfo/ltp