From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] lapi/fsmount: resolve conflict in different header files
Date: Fri, 5 Aug 2022 09:38:23 +0200 [thread overview]
Message-ID: <YuzI7w3MnBgdiaza@pevik> (raw)
In-Reply-To: <20220805063401.1647479-3-liwang@redhat.com>
Hi Li,
> The latest glibc added new wrappers (e.g. mount_setattr, fsopen) support in
> sys/mount.h, which partly conflicts with linux/mount.h at the same time.
> We need to make adjustments to header files to fix compiling error on
> different platforms.
thanks for fixing this!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM, with suggestion.
> +#include <sys/mount.h>
> #include "tst_test.h"
> #include "lapi/fsmount.h"
How about instead adding it to the tests to add it to lapi/fsmount.h ?
#include <sys/mount.h>
#ifndef HAVE_FSOPEN
# ifdef HAVE_LINUX_MOUNT_H
# include <linux/mount.h>
# endif
Works on rawhide
https://github.com/pevik/ltp/actions/runs/2802006779
and on the rest
https://github.com/pevik/ltp/actions/runs/2801968366
and my branch li/fix-compiling-errors.fixes
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-08-05 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 6:33 [LTP] [PATCH 0/2] fix compiling errors on fedora-rawhide Li Wang
2022-08-05 6:34 ` [LTP] [PATCH 1/2] lapi/pidfd: adding pidfd header file Li Wang
2022-08-05 7:14 ` Petr Vorel
2022-08-05 10:04 ` Li Wang
2022-08-05 10:36 ` Petr Vorel
2022-08-05 6:34 ` [LTP] [PATCH 2/2] lapi/fsmount: resolve conflict in different header files Li Wang
2022-08-05 7:38 ` Petr Vorel [this message]
2022-08-05 9:44 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuzI7w3MnBgdiaza@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.