Re: [PATCH v3 08/10] drivers/char: mark DMA buffers as reserved for the XHCI

["Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

On Fri, Aug 05, 2022 at 09:05:27AM +0200, Jan Beulich wrote:
> On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote:
> > @@ -1046,13 +1047,20 @@ static struct uart_driver dbc_uart_driver = {
> >      .flush = dbc_uart_flush,
> >  };
> >  
> > -static struct xhci_trb evt_trb[DBC_TRB_RING_CAP];
> > -static struct xhci_trb out_trb[DBC_TRB_RING_CAP];
> > -static struct xhci_trb in_trb[DBC_TRB_RING_CAP];
> > -static struct xhci_erst_segment erst __aligned(64);
> > -static struct xhci_dbc_ctx ctx __aligned(64);
> 
> Why the change from 64 ...
> 
> > -static uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE);
> > -static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT];
> > +struct dbc_dma_bufs {
> > +    struct xhci_trb evt_trb[DBC_TRB_RING_CAP];
> > +    struct xhci_trb out_trb[DBC_TRB_RING_CAP];
> > +    struct xhci_trb in_trb[DBC_TRB_RING_CAP];
> > +    uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE);
> > +    struct xhci_erst_segment erst __aligned(16);
> > +    struct xhci_dbc_ctx ctx __aligned(16);
> 
> ... to 16?

That's rebase fail, it should be changed to 16 initial patch too.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]