All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, kuba@kernel.org
Cc: rafael@kernel.org, linux-pm@vger.kernel.org, vadimp@mellanox.com,
	davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, vadimp@nvidia.com,
	petrm@nvidia.com, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Subject: Re: [PATCH v4] Revert "mlxsw: core: Add the hottest thermal zone detection"
Date: Wed, 17 Aug 2022 19:11:12 +0300	[thread overview]
Message-ID: <Yv0TIH0LsjFJwV0L@shredder> (raw)
In-Reply-To: <20220817153040.2464245-1-daniel.lezcano@linaro.org>

On Wed, Aug 17, 2022 at 05:30:40PM +0200, Daniel Lezcano wrote:
> This reverts commit 2dc2f760052da4925482ecdcdc5c94d4a599153c and
> commit 6f73862fabd93213de157d9cc6ef76084311c628.
> 
> As discussed in the thread:
> 
> https://lore.kernel.org/all/f3c62ebe-7d59-c537-a010-bff366c8aeba@linaro.org/
> 
> the feature provided by commits 2dc2f760052da and 6f73862fabd93 is
> actually already handled by the thermal framework via the cooling
> device state aggregation, thus all this code is pointless.
> 
> The revert conflicts with the following changes:
>  - 7f4957be0d5b8: thermal: Use mode helpers in drivers
>  - 6a79507cfe94c: mlxsw: core: Extend thermal module with per QSFP module thermal zones
> 
> These conflicts were fixed and the resulting changes are in this patch.
> 
> Both reverts are in the same change as requested by Ido Schimmel:
> 
> https://lore.kernel.org/all/Yvz7+RUsmVco3Xpj@shredder/
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Tested-by: Vadim Pasternak <vadimp@nvidia.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Jakub, Daniel wants to route this patch via his tree. Do you mind?
I spoke with Vadim earlier this week and we do not expect changes to
this file during the current cycle.

Thanks

  reply	other threads:[~2022-08-17 16:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 15:30 [PATCH v4] Revert "mlxsw: core: Add the hottest thermal zone detection" Daniel Lezcano
2022-08-17 16:11 ` Ido Schimmel [this message]
2022-08-17 18:21   ` Jakub Kicinski
2022-08-18  7:23     ` Daniel Lezcano
2022-08-23 12:42 ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv0TIH0LsjFJwV0L@shredder \
    --to=idosch@nvidia.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=rafael@kernel.org \
    --cc=vadimp@mellanox.com \
    --cc=vadimp@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.