From: Jason Gunthorpe <jgg@nvidia.com>
To: Abhishek Sahu <abhsahu@nvidia.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Kevin Tian <kevin.tian@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-pm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v6 5/5] vfio/pci: Implement VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP
Date: Wed, 17 Aug 2022 14:40:47 -0300 [thread overview]
Message-ID: <Yv0oH23UYbI/LI+X@nvidia.com> (raw)
In-Reply-To: <5363303b-30bb-3c4a-bf42-426dd7f8138d@nvidia.com>
On Wed, Aug 17, 2022 at 09:34:30PM +0530, Abhishek Sahu wrote:
> On 8/17/2022 7:23 PM, Jason Gunthorpe wrote:
> > On Wed, Aug 17, 2022 at 10:43:23AM +0530, Abhishek Sahu wrote:
> >
> >> +static int
> >> +vfio_pci_core_pm_entry_with_wakeup(struct vfio_device *device, u32 flags,
> >> + void __user *arg, size_t argsz)
> >
> > This should be
> > struct vfio_device_low_power_entry_with_wakeup __user *arg
> >
>
> Thanks Jason.
>
> I can update this.
>
> But if we look the existing code, for example
> (vfio_ioctl_device_feature_mig_device_state()), then there it still uses
> 'void __user *arg' only. Is this a new guideline which we need to take
> care ?
I just sent a patch that fixes that too
> Do we need to keep the IOCTL name alphabetically sorted in the case list.
> Currently, I have added in the order of IOCTL numbers.
It is generally a good practice to sort lists of things.
Jason
next prev parent reply other threads:[~2022-08-17 17:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 5:13 [PATCH v6 0/5] vfio/pci: power management changes Abhishek Sahu
2022-08-17 5:13 ` [PATCH v6 1/5] vfio: Add the device features for the low power entry and exit Abhishek Sahu
2022-08-17 5:13 ` [PATCH v6 2/5] vfio: Increment the runtime PM usage count during IOCTL call Abhishek Sahu
2022-08-17 5:13 ` [PATCH v6 3/5] vfio/pci: Mask INTx during runtime suspend Abhishek Sahu
2022-08-17 5:13 ` [PATCH v6 4/5] vfio/pci: Implement VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY/EXIT Abhishek Sahu
2022-08-17 5:13 ` [PATCH v6 5/5] vfio/pci: Implement VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP Abhishek Sahu
2022-08-17 13:53 ` Jason Gunthorpe
2022-08-17 16:04 ` Abhishek Sahu
2022-08-17 17:40 ` Jason Gunthorpe [this message]
2022-08-18 17:01 ` Abhishek Sahu
2022-08-25 22:32 ` Alex Williamson
2022-08-26 14:30 ` Abhishek Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv0oH23UYbI/LI+X@nvidia.com \
--to=jgg@nvidia.com \
--cc=abhsahu@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=cohuck@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=rafael@kernel.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.