From: Jason Gunthorpe <jgg@nvidia.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Alistair Popple <apopple@nvidia.com>,
linux-mm@kvack.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, "Sierra Guiza,
Alejandro (Alex)" <alex.sierra@amd.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
Felix Kuehling <Felix.Kuehling@amd.com>,
Logan Gunthorpe <logang@deltatee.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Muchun Song <songmuchun@bytedance.com>,
Ralph Campbell <rcampbell@nvidia.com>,
David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v4 2/2] mm/gup.c: Refactor check_and_migrate_movable_pages()
Date: Wed, 17 Aug 2022 19:50:06 -0300 [thread overview]
Message-ID: <Yv1wntznpzSXuTYh@nvidia.com> (raw)
In-Reply-To: <de9a3db9-6130-fe07-88ec-7e728ff5701c@nvidia.com>
On Wed, Aug 17, 2022 at 01:35:12PM -0700, John Hubbard wrote:
> How's this look to you:
>
> collected = collect_longterm_unpinnable_pages(&movable_page_list,
> nr_pages, pages);
> if (collected == 0)
> return 0;
>
> ret = migrate_longterm_unpinnable_pages(&movable_page_list, nr_pages,
> pages);
>
> /* If we got here, we have some unpinnable pages... */
>
> if (ret == 0) {
> /*
> * ...and we successfully migrated those pages. Which means that
> * the caller should retry the operation now.
> */
> ret = -EAGAIN;
return -EAGAIN
> }
>
> return ret;
But why return 0 from the helper function in the first place?
Jason
next prev parent reply other threads:[~2022-08-17 22:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 2:13 [PATCH v4 1/2] mm/gup.c: Don't pass gup_flags to check_and_migrate_movable_pages() Alistair Popple
2022-08-12 2:13 ` [PATCH v4 2/2] mm/gup.c: Refactor check_and_migrate_movable_pages() Alistair Popple
2022-08-12 7:05 ` John Hubbard
2022-08-15 16:15 ` Jason Gunthorpe
2022-08-16 5:29 ` Alistair Popple
2022-08-16 11:29 ` Jason Gunthorpe
2022-08-17 2:01 ` Alistair Popple
2022-08-17 12:09 ` Jason Gunthorpe
2022-08-17 20:35 ` John Hubbard
2022-08-17 22:50 ` Jason Gunthorpe [this message]
2022-08-17 23:05 ` John Hubbard
2022-08-17 23:24 ` Alistair Popple
2022-08-17 23:40 ` Jason Gunthorpe
2022-08-12 12:57 ` [PATCH v4 1/2] mm/gup.c: Don't pass gup_flags to check_and_migrate_movable_pages() Matthew Wilcox
2022-08-12 18:02 ` John Hubbard
2022-08-12 18:11 ` Matthew Wilcox
2022-08-15 5:52 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv1wntznpzSXuTYh@nvidia.com \
--to=jgg@nvidia.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kch@nvidia.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=rcampbell@nvidia.com \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.