From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Tim Van Patten <timvp@google.com>
Cc: rrangel@chromium.org, robbarnes@google.com,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] platform/chrome: cros_ec: Send host event for prepare/complete
Date: Thu, 18 Aug 2022 04:08:11 +0000 [thread overview]
Message-ID: <Yv27K4+rLfskcQdm@google.com> (raw)
In-Reply-To: <20220802113957.v3.1.I2c8c550183162e7594309b66d19af696b8d84552@changeid>
On Tue, Aug 02, 2022 at 11:40:08AM -0600, Tim Van Patten wrote:
> Update cros_ec_lpc_pm_ops to call cros_ec_lpc_prepare() during PM
> .prepare() and cros_ec_lpc_complete() during .complete(). This allows the
> EC to log entry/exit of AP's suspend/resume more accurately.
As what I commented on [1], the term "host event" in the commit title is
confusing. Also, as this is a cros_ec_lpc specific patch, please change
the prefix.
[1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220706205136.v2.1.Ic7a7c81f880ab31533652e0928aa6e687bb268b5@changeid/#24934911
> -static int cros_ec_lpc_resume(struct device *dev)
> +static void cros_ec_lpc_complete(struct device *dev)
> {
> struct cros_ec_device *ec_dev = dev_get_drvdata(dev);
> + int ret;
> +
> + ret = cros_ec_resume(ec_dev);
>
> - return cros_ec_resume(ec_dev);
> + dev_info(dev, "EC resume completed: ret = %d\n", ret);
cros_ec_resume() always returns 0.
next prev parent reply other threads:[~2022-08-18 4:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 17:40 [PATCH v3] platform/chrome: cros_ec: Send host event for prepare/complete Tim Van Patten
2022-08-17 21:55 ` Raul Rangel
2022-08-18 4:08 ` Tzung-Bi Shih [this message]
2022-08-22 16:21 ` Tim Van Patten
2022-08-23 2:49 ` Tzung-Bi Shih
2022-08-23 16:00 ` Tim Van Patten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv27K4+rLfskcQdm@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robbarnes@google.com \
--cc=rrangel@chromium.org \
--cc=timvp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.