From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6477C00140 for ; Thu, 18 Aug 2022 13:45:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SxEXSDY0ps1CrZLqV1iI6ved8ZO7dXsWRYP+3/EboL8=; b=qF+yxCRxj9ovExrM8IBHPBGWbH kr6sEyoSfitRSRE17bIfySw3UpPauqfY5KAA2trPAKjVFkuKqw1xWNwRUwDoknAEBCWcfimf7vR+u n9K2AeeOMCMpP5YmL2pnsVEYqytMG5m+zy3xs8YtabBNgISwakG1J96wPWfXN+2KaT6nADSZ3ovfB lt20CqNyZGY44jFXVSjJTVYv+0ZiyDlTJoNmjIEfIuE+M/Wo/v48bOCrNJjHxTFCjp5i6tEuw3Ntt 4vDQJbddnkGx8ythA5UDyRCYYt0OAlXkmPAntaxnMJuy84zVeusRIxqH9EbR859V0rrn8FXoWMOPy YEnd3CXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOfoU-005cs0-0N; Thu, 18 Aug 2022 13:43:58 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOfe1-005SVN-A6 for linux-arm-kernel@lists.infradead.org; Thu, 18 Aug 2022 13:33:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 16EE961662; Thu, 18 Aug 2022 13:33:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACD50C433D6; Thu, 18 Aug 2022 13:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660829587; bh=nep9dU+KaKPZJtCkx3Rde/8P3zokPC6h+n6I1fL4t7w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d0j+bM4mhT0o0qVteG7qRRYc48gd8ORpehIb03LF/kSaCFJIrtP48FpfVINTRckoR cQqnfDUUMl2uA7doWI/SIkeyaFLiVVe2FrSEvS7Ontlk1VvF0zqrFxdIyQK6ySYCGd iiPKhY7ZgU7tpIimDa50854JtfW5oHYxqP5di3PZwF8jA9F1xzix+b8iv7CtVujXxY pRzmui5CGZPDlh7NA+MzkUjsi8UZnDhlQfnj6ZOmbReNIZlpjuyjR+9Hu3AFT0V5k3 HwZEf+JIhof+oGvUfQUJ4df30Cfsn27GnWFN1Bgcs9FlTYc/EGs0lUfExzxbiUiMPs sTNA9IBRvXz8Q== Date: Thu, 18 Aug 2022 14:33:02 +0100 From: Mark Brown To: Mark Rutland Cc: Will Deacon , Catalin Marinas , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel Subject: Re: [PATCH] arm64/cache: Fix cache_type_cwg() for register generation Message-ID: References: <20220817160246.420734-1-broonie@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Cookie: Logic is the chastity belt of the mind! X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220818_063309_422156_64CBD687 X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8468085702103081837==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8468085702103081837== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MkwaxCF7D+yAe9wp" Content-Disposition: inline --MkwaxCF7D+yAe9wp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 18, 2022 at 02:20:18PM +0100, Mark Rutland wrote: > On Wed, Aug 17, 2022 at 07:22:26PM +0100, Mark Brown wrote: > > On Wed, Aug 17, 2022 at 05:56:24PM +0100, Mark Rutland wrote: > > > | #define CTR_CWG(ctr) SYS_FIELD_GET(CTR_EL0, CWG, ctr) > > I think if we're going to define that sort of per bitfield accessor > > macro (which is certainly a valid and reasonable thing to do) we should > > be having the script generate them rather than open coding them but > > that's getting out of scope for a fix and should be done separately. > I'm not asking for us to do that for *every* bitfield accessor, I'm just asking > for us to be locally consistent within cache.h. If we're going to introduce that sort of rule it should probably be a general thing rather than a per header thing, the CTR_L1IP() thing was a preexisting thing that was just converted in place rather than a style we were trying to say was a good idea that should be replicated. > I'm also happy to use SYS_FIELD_GET() directly within cache_type_cwg(), and not > define CTR_CWG(). Sure, that's less problematic and indeed currently going through my testing. --MkwaxCF7D+yAe9wp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmL+P40ACgkQJNaLcl1U h9B4Fwf/dvYsUCrlSeLAmDvqqxL8VF5UmqNHCptqB7HgEa2pIaUsYknaeFLw3p2o b7yatUfzbSAN7MWUXB1q7SWSG4JlVdeg2uY3ZyprQ4X7YFMAK2NxA0/y6EanIIep /OLJxHpAueJRDTb7aYKiJ4V6RuzLBNdIBsPTLx2KKLv5VTII60ZuMz+w0AxdvQlH uPm9QgolxFgrC6lwzRRJ2r7DIw9P081HoIVDbbTu17Of7BPsumRfykQNcvBZ4jWk 17EWGPFX/wDsDYjfySWG4WwFyLse9CgB9f1U7CdAok3tttFmL8qu+cfwNZzrq0kU 3ctYv+rCeUlZKy1TyGv2BBMKK2qjew== =D3oN -----END PGP SIGNATURE----- --MkwaxCF7D+yAe9wp-- --===============8468085702103081837== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8468085702103081837==--