From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10743C00140 for ; Thu, 18 Aug 2022 13:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244526AbiHRNLp (ORCPT ); Thu, 18 Aug 2022 09:11:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244862AbiHRNLo (ORCPT ); Thu, 18 Aug 2022 09:11:44 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EAA260685 for ; Thu, 18 Aug 2022 06:11:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 7FA2CCE2052 for ; Thu, 18 Aug 2022 13:11:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5845EC433D6; Thu, 18 Aug 2022 13:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660828299; bh=UeEBwtYdVcW8MGTiAlm79zj6Pdak+BrQZ+GM+wxaER0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QOyZjqv+Ndr5TdWO152lhD+v3d0kiNxajUsUNYUPUr/bASlSKnk/j3gst9pddXejB XuaB556HYhhnMTxX1DzqtuI2iua822O5gpF8yZixTFDZnFinzGRyfocAAs0yHE0KeL xiYbzYb7PmZgQGNhBaux5B6z+vAMQ/msRpRKTW5A= Date: Thu, 18 Aug 2022 15:11:37 +0200 From: Greg KH To: Pavel Rojtberg Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, Santosh De Massari Subject: Re: [PATCH 3/4] Input: xpad - Poweroff XBOX360W on mode button long press Message-ID: References: <20220818130021.487410-1-rojtberg@gmail.com> <20220818130021.487410-4-rojtberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818130021.487410-4-rojtberg@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, Aug 18, 2022 at 03:00:20PM +0200, Pavel Rojtberg wrote: > From: Santosh De Massari > > Newer gamepads turn themselves off when the mode button is held down. > For XBOX360W gamepads we must do this in the driver. > > Do not use BIT() macro for consistency within the file. You can fix the file up to properly use the BIT() macro :) thanks, greg k-h