From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6630EC00140 for ; Thu, 18 Aug 2022 13:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nnY8p6L5clArVzXa0TNCRDTvrN/SQlzcXieWPuNvGiQ=; b=ft20+UcmHyacY5 d74rUGTK6YP53GtT//RpSGKNW4azZD1dQXZTgAT86L7jr0AaHjQjlnBji4i/YJCqupgel3PUcgClh LCyZfGfhn6gXJD0n2PsPhf0sRAdIRTSEntR227RVkrBSHWxjO690593zuDIUtwkRWQ0snsVswVDVp Np9Wbi2ajuJT0MEb0+uLrilRAawqA5OfH4amFPJskKoE87WYBgqX7T4FW7ddnZCPvhX6Fjs0Zsrzc 2yS+c3H9t5kHS23ojbE2JI2aHrHn0uULXnAQyXV1VC4DepIh/d5pZ9yQU//w57DY7/oK5IwYQ8DjC FbZAPuKqYpNSl1m1fboQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOfj9-005XXL-Ox; Thu, 18 Aug 2022 13:38:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOfRm-005HQE-2I for linux-arm-kernel@lists.infradead.org; Thu, 18 Aug 2022 13:20:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE019106F; Thu, 18 Aug 2022 06:20:29 -0700 (PDT) Received: from FVFF77S0Q05N.cambridge.arm.com (FVFF77S0Q05N.cambridge.arm.com [10.1.38.153]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 945733F70D; Thu, 18 Aug 2022 06:20:27 -0700 (PDT) Date: Thu, 18 Aug 2022 14:20:18 +0100 From: Mark Rutland To: Mark Brown Cc: Will Deacon , Catalin Marinas , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel Subject: Re: [PATCH] arm64/cache: Fix cache_type_cwg() for register generation Message-ID: References: <20220817160246.420734-1-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220818_062030_190065_B096C71D X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 17, 2022 at 07:22:26PM +0100, Mark Brown wrote: > On Wed, Aug 17, 2022 at 05:56:24PM +0100, Mark Rutland wrote: > > > 5b345e39d3ebc213 ("arm64/sysreg: Standardise naming for CTR_EL0 fields") > > > ... and instead have: > > > | #define CTR_CWG(ctr) SYS_FIELD_GET(CTR_EL0, CWG, ctr) > > I think if we're going to define that sort of per bitfield accessor > macro (which is certainly a valid and reasonable thing to do) we should > be having the script generate them rather than open coding them but > that's getting out of scope for a fix and should be done separately. I'm not asking for us to do that for *every* bitfield accessor, I'm just asking for us to be locally consistent within cache.h. I'm also happy to use SYS_FIELD_GET() directly within cache_type_cwg(), and not define CTR_CWG(). Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel