All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: dsterba@suse.cz, Boris Burkov <boris@bur.io>,
	linux-btrfs@vger.kernel.org, kernel-team@fb.com,
	linux-fscrypt@vger.kernel.org
Subject: Re: [PATCH v4] btrfs: send: add support for fs-verity
Date: Thu, 18 Aug 2022 17:51:49 +0000	[thread overview]
Message-ID: <Yv58NctXwBzG1Ry1@gmail.com> (raw)
In-Reply-To: <20220818174010.GO13489@twin.jikos.cz>

On Thu, Aug 18, 2022 at 07:40:10PM +0200, David Sterba wrote:
> On Wed, Aug 17, 2022 at 09:57:22PM -0700, Eric Biggers wrote:
> > On Mon, Aug 15, 2022 at 01:54:28PM -0700, Boris Burkov wrote:
> > > diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> > > index e7671afcee4f..9e8679848d54 100644
> > > --- a/fs/btrfs/send.c
> > > +++ b/fs/btrfs/send.c
> > > @@ -3,6 +3,7 @@
> > >   * Copyright (C) 2012 Alexander Block.  All rights reserved.
> > >   */
> > >  
> > > +#include "linux/compiler_attributes.h"
> > 
> > I don't understand the purpose of this include.  And why is it in quotes?
> 
> It compiles without it so I've deleted it.
> 
> > 
> > Otherwise this patch looks good to me.
> 
> I assume it's acked-by/reviewed-by namely for the fs-verity changes,
> right?

Yes if you're just fixing that without a new version, you can add:

Acked-by: Eric Biggers <ebiggers@google.com>

(By the way, please fix your email client to not generate a Mail-Followup-To
header, as it causes replies to move everyone to "To".  If you're using mutt,
you need 'set followup_to = no' in your muttrc.)

- Eric

  reply	other threads:[~2022-08-18 17:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 20:54 [PATCH v4] btrfs: send: add support for fs-verity Boris Burkov
2022-08-16  9:09 ` kernel test robot
2022-08-18  4:57 ` Eric Biggers
2022-08-18 17:40   ` David Sterba
2022-08-18 17:51     ` Eric Biggers [this message]
2022-08-18 18:29   ` Boris Burkov
2022-08-18 17:32 ` David Sterba
2022-08-18 18:49   ` Boris Burkov
2022-08-22 12:50     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv58NctXwBzG1Ry1@gmail.com \
    --to=ebiggers@kernel.org \
    --cc=boris@bur.io \
    --cc=dsterba@suse.cz \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.