Re: [RFC PATCH net-next] net: ngbe: Add build support for ngbe

[Andrew Lunn <andrew@lunn.ch>]

> +static int ngbe_probe(struct pci_dev *pdev,
> +		      const struct pci_device_id __always_unused *ent)
> +{
> +	struct ngbe_adapter *adapter = NULL;
> +	struct net_device *netdev;
> +	int err;
> +
> +	err = pci_enable_device_mem(pdev);
> +	if (err)
> +		return err;
> +
> +	err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
> +	if (err) {
> +		dev_err(&pdev->dev,
> +			"No usable DMA configuration, aborting\n");
> +		goto err_pci_disable_dev;
> +	}
> +
> +	err = pci_request_selected_regions(pdev,
> +					   pci_select_bars(pdev, IORESOURCE_MEM),
> +					   ngbe_driver_name);
> +	if (err) {
> +		dev_err(&pdev->dev,
> +			"pci_request_selected_regions failed 0x%x\n", err);
> +		goto err_pci_disable_dev;
> +	}

nitpick: Since include/linux/errno.h uses decimal, i think it would be
better to print the error code in decimal. 

Otherwise this looks pretty good.

	  Andrew