From: Sean Christopherson <seanjc@google.com>
To: Li kunyu <kunyu@nfschina.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] kvm/kvm_main: The npages variable does not need to be initialized and assigned, it is used after assignment
Date: Thu, 18 Aug 2022 23:51:54 +0000 [thread overview]
Message-ID: <Yv7QmoHtVDNU7dYk@google.com> (raw)
In-Reply-To: <20220812103009.8362-1-kunyu@nfschina.com>
Please use "KVM: " for the shortlog scope, and write an actual shortlog. E.g.
KVM: Drop unnecessary initialization of "npages" in hva_to_pfn_slow()
On Fri, Aug 12, 2022, Li kunyu wrote:
> The npages variable does not need to be initialized and assigned, it is
> first assigned before it is used.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
With a proper shortlog,
Reviewed-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2022-08-18 23:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 10:15 [PATCH 1/5] kvm/kvm_main: Modify the offset type to size_t, which is consistent with the calling function Li kunyu
2022-08-12 10:22 ` [PATCH 2/5] kvm/kvm_main: remove unnecessary (void*) conversions Li kunyu
2022-08-12 10:24 ` [PATCH 3/5] kvm/kvm_main: The ops pointer variable does not need to be initialized and assigned, it is first allocated a memory address Li kunyu
2022-08-18 23:55 ` Sean Christopherson
2022-08-12 10:30 ` [PATCH 4/5] kvm/kvm_main: The npages variable does not need to be initialized and assigned, it is used after assignment Li kunyu
2022-08-18 23:51 ` Sean Christopherson [this message]
2022-08-19 1:32 ` Li kunyu
2022-08-12 10:31 ` [PATCH 5/5] kvm/kvm_main: remove unnecessary (const void*) conversions Li kunyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv7QmoHtVDNU7dYk@google.com \
--to=seanjc@google.com \
--cc=kunyu@nfschina.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.