From: Greg KH <gregkh@linuxfoundation.org>
To: Abhishek Shah <abhishek.shah@columbia.edu>
Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org,
changlianzhi@uniontech.com, dmitry.torokhov@gmail.com,
johan@kernel.org, Gabriel Ryan <gabe@cs.columbia.edu>
Subject: Re: data-race in do_compute_shiftstate / vt_get_shift_state
Date: Fri, 19 Aug 2022 09:06:03 +0200 [thread overview]
Message-ID: <Yv82W6FRCbYuRAdB@kroah.com> (raw)
In-Reply-To: <CAEHB24_uZNoJ9+B-XVdMcW0z1EGwpx5XL4rdEUtNqofsmYSWVw@mail.gmail.com>
On Thu, Aug 18, 2022 at 08:25:00PM -0400, Abhishek Shah wrote:
> Hi all,
>
> We found a data race involving the *shift_state * variable. Although we see
> that the race involves a function which has a comment about being racy
> <https://elixir.bootlin.com/linux/v5.18-rc5/source/drivers/tty/vt/vt.c#L3174>,
> we are unsure of its security implications as the remaining switch cases
> have a console_lock() call but this one
> <https://elixir.bootlin.com/linux/v5.18-rc5/source/drivers/tty/vt/vt.c#L3224>
> does not. Please let us know what you think.
Can you propose a patch that solves the problem for you in your testing
that we can review?
thanks,
greg k-h
parent reply other threads:[~2022-08-19 7:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAEHB24_uZNoJ9+B-XVdMcW0z1EGwpx5XL4rdEUtNqofsmYSWVw@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv82W6FRCbYuRAdB@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abhishek.shah@columbia.edu \
--cc=changlianzhi@uniontech.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gabe@cs.columbia.edu \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.