From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, senozhatsky@chromium.org,
ngupta@vflare.org, minchan@kernel.org, avromanov@sberdevices.ru
Subject: Re: + zsmalloc-remove-unnecessary-size_class-null-check.patch added to mm-unstable branch
Date: Fri, 19 Aug 2022 21:04:35 +0900 [thread overview]
Message-ID: <Yv98U22CMElN6OL7@google.com> (raw)
In-Reply-To: <20220811212201.71ECFC433D6@smtp.kernel.org>
On (22/08/11 14:22), Andrew Morton wrote:
> pool->size_class array elements can't be NULL, so this check
> is not needed.
>
> In the whole code, we assign pool->size_class[i] values that are
> not NULL. Releasing memory for these values occurs in the
> zs_destroy_pool() function, which also releases and destroys the pool.
>
> In addition, in the zs_stats_size_show() and async_free_zspage(),
> with similar iterations over the array, we don't check it for NULL
> pointer.
>
> Link: https://lkml.kernel.org/r/20220811153755.16102-3-avromanov@sberdevices.ru
> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
prev parent reply other threads:[~2022-08-19 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 21:22 + zsmalloc-remove-unnecessary-size_class-null-check.patch added to mm-unstable branch Andrew Morton
2022-08-19 12:04 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv98U22CMElN6OL7@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=avromanov@sberdevices.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.