From: Jiri Pirko <jiri@resnulli.us>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jiri Pirko <jiri@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: cmd_sb_occ_show doesn't call dl_put_opts
Date: Mon, 8 Aug 2022 09:16:40 +0200 [thread overview]
Message-ID: <YvC4WO2y4+RCTr1G@nanopsycho> (raw)
In-Reply-To: <fd4da86c-e806-8261-970a-fc563758a9e1@intel.com>
Fri, Aug 05, 2022 at 10:18:22PM CEST, jacob.e.keller@intel.com wrote:
>Hey Jiri,
>
>I noticed while looking at implementing policy checking support in
>devlink that the cmd_sb_occ_show calls dl_argv_parse but then doesn't
>call dl_put_opts, so it doesn't seem to be sending any of the attributes
>down to the kernel.
>
>I am guessing this is not done on purpose, and is just an oversight,
>caused by needing to send two different netlink messages.
>
>It looks like the code could use a dl_argc check to determine whether to
>use NLM_F_DUMP and call dl_put_opts to ensure the netlink attributes get
>added..?
Correct. Currently we are doing dump all the time. Should be fixed.
>
>Thanks,
>Jake
prev parent reply other threads:[~2022-08-08 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 20:18 cmd_sb_occ_show doesn't call dl_put_opts Jacob Keller
2022-08-08 7:16 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvC4WO2y4+RCTr1G@nanopsycho \
--to=jiri@resnulli.us \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.