All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: mario.limonciello@amd.com
Cc: linux-gpio@vger.kernel.org
Subject: [bug report] pinctrl: amd: Use unicode for debugfs output
Date: Mon, 8 Aug 2022 13:28:53 +0300	[thread overview]
Message-ID: <YvDlZaydFKN5loe/@kili> (raw)

Hello Mario Limonciello,

The patch e8129a076a50: "pinctrl: amd: Use unicode for debugfs
output" from Jul 22, 2022, leads to the following Smatch static
checker warning:

drivers/pinctrl/pinctrl-amd.c:249 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x8c'
drivers/pinctrl/pinctrl-amd.c:288 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x8e'
drivers/pinctrl/pinctrl-amd.c:294 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x85'
drivers/pinctrl/pinctrl-amd.c:300 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x85'
drivers/pinctrl/pinctrl-amd.c:306 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x85'
drivers/pinctrl/pinctrl-amd.c:320 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x86'
drivers/pinctrl/pinctrl-amd.c:326 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x86'
drivers/pinctrl/pinctrl-amd.c:326 amd_gpio_dbg_show() warn: format string contains non-ascii character '\xe2'
drivers/pinctrl/pinctrl-amd.c:370 amd_gpio_dbg_show() warn: format string contains non-ascii character '\xe2'

I didn't add this Smatch check and I don't know the rules for this so
when someone adds something that basically looks sane, I don't report
it.


drivers/pinctrl/pinctrl-amd.c
    247                 seq_printf(s, "GPIO bank%d\n", bank);
    248                 for (; i < pin_num; i++) {
    249                         seq_printf(s, "📌%d\t", i);
                                               ^
In Gnome this looks like a thumbtack.

...

    279 
    280                         if (pin_reg & BIT(INTERRUPT_MASK_OFF))
    281                                 interrupt_mask = "-";
    282                         else
    283                                 interrupt_mask = "+";
    284                         seq_printf(s, "int %s (🎭 %s)| active-%s| %s-🔫| ",

Gnome emojis seem difficult to read.  Theatre masks and a water gun?

    285                                    interrupt_enable,
    286                                    interrupt_mask,
    287                                    active_level,
--> 288                                    level_trig);
    289 
    290                         if (pin_reg & BIT(WAKE_CNTRL_OFF_S0I3))
    291                                 wake_cntrl0 = "+";
    292                         else
    293                                 wake_cntrl0 = "∅";
    294                         seq_printf(s, "S0i3 🌅 %s| ", wake_cntrl0);


Sunrise emoji?

...

    369                         snprintf(debounce_value, sizeof(debounce_value), "%u", time * unit);
    370                         seq_printf(s, "debounce %s (⏰ %sus)| ", debounce_enable, debounce_value);

Alarm clock.

    371                         seq_printf(s, " 0x%x\n", pin_reg);
    372                 }
    373         }
    374 }

regards,
dan carpenter

             reply	other threads:[~2022-08-08 10:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 10:28 Dan Carpenter [this message]
2022-08-08 12:33 ` [bug report] pinctrl: amd: Use unicode for debugfs output Mario Limonciello
2022-08-08 12:47   ` Dan Carpenter
2022-08-08 16:06   ` Kent Gibson
2022-08-08 18:21     ` Limonciello, Mario
2022-08-09  1:30       ` Kent Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvDlZaydFKN5loe/@kili \
    --to=dan.carpenter@oracle.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.