From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F5FC25B0C for ; Mon, 8 Aug 2022 13:28:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242871AbiHHN2j (ORCPT ); Mon, 8 Aug 2022 09:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243338AbiHHN2g (ORCPT ); Mon, 8 Aug 2022 09:28:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 367C4A462 for ; Mon, 8 Aug 2022 06:28:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D1146B80E84 for ; Mon, 8 Aug 2022 13:28:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FA52C433D6; Mon, 8 Aug 2022 13:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659965312; bh=Oib6Kqe9X+xupZNFliGRXSFpKQ3+Mlm/9Ff+a16/1oM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kao42x/JUxfvPK+7RSRmtHAlUKKgoByIF+35HTjt/qNjxl2KemdH2q/fBUa19tLlu LViSwp4+dwyowMM1I1GYP0hT4i81/2/1OBrwtfkBiSciUWYFqpdemXMVCjRXt7/Xo9 sXtUonXjaHZ68EkB2SL6bxdrfM//R0DcMSNSibYc= Date: Mon, 8 Aug 2022 15:28:29 +0200 From: Greg KH To: Alexander Grund Cc: stable@vger.kernel.org Subject: Re: [PATCH 4.9 0/1] selinux: drop super_block backpointer from superblock_security_struct Message-ID: References: <20220808115922.331003-1-theflamefire89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220808115922.331003-1-theflamefire89@gmail.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Aug 08, 2022 at 01:59:21PM +0200, Alexander Grund wrote: > This backports a commit from upstream which I would consider a cleanup > as well as a (minor) performance fix due to less memory being used and > avoiding an unneccessary pointer dereferencing, i.e. the change > from `sbsec->sb->s_root` to `sb->s_root`. > > However as it changes the `superblock_security_struct` please check if > this violates any API/ABI stability requirements which I'm not aware of. There is no internal stable API/ABI in the kernel, including in the stable releases. But, we only take patches that actually do something. This one doesn't do anything at all, and has no measurable performance or bugfix that I can determine at all. So no need for it, sorry, greg k-h