From: Lee Jones <lee.jones@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Andy Shevchenko <andy@kernel.org>,
Lee Jones <lee@kernel.org>
Subject: Re: [RESEND][PATCH v1 8/9] mfd: intel_soc_pmic_bxtwc: Support IRQ chip hierarchy
Date: Mon, 8 Aug 2022 16:20:12 +0100 [thread overview]
Message-ID: <YvEprE7YwuwaMXwL@google.com> (raw)
In-Reply-To: <20220718122328.8287-8-andriy.shevchenko@linux.intel.com>
On Mon, 18 Jul 2022, Andy Shevchenko wrote:
No commit message.
Probably needs to justify why it's calling a function denoted for
internal use only.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/intel_soc_pmic_bxtwc.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c b/drivers/mfd/intel_soc_pmic_bxtwc.c
> index 8dac0d41f64f..f9842ff44b3f 100644
> --- a/drivers/mfd/intel_soc_pmic_bxtwc.c
> +++ b/drivers/mfd/intel_soc_pmic_bxtwc.c
> @@ -422,8 +422,10 @@ static int bxtwc_add_chained_irq_chip(struct intel_soc_pmic *pmic,
> return dev_err_probe(pmic->dev, irq, "Failed to get parent vIRQ(%d) for chip %s\n",
> pirq, chip->name);
>
> - return devm_regmap_add_irq_chip(pmic->dev, pmic->regmap, irq, irq_flags,
> - 0, chip, data);
> + return __devm_regmap_add_irq_chip(pmic->dev, pmic->regmap, irq,
> + irq_flags, 0,
> + regmap_irq_get_domain(pdata),
> + chip, data);
> }
>
> static int bxtwc_probe(struct platform_device *pdev)
--
DEPRECATED: Please use lee@kernel.org
next prev parent reply other threads:[~2022-08-08 15:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 12:23 [RESEND][PATCH v1 1/9] mfd: intel_soc_pmic_crc: Use devm_regmap_add_irq_chip() Andy Shevchenko
2022-07-18 12:23 ` [RESEND][PATCH v1 2/9] mfd: intel_soc_pmic_crc: Convert to use i2c_get/set_clientdata() Andy Shevchenko
2022-07-18 12:23 ` [RESEND][PATCH v1 3/9] mfd: intel_soc_pmic_crc: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc Andy Shevchenko
2022-07-18 12:23 ` [RESEND][PATCH v1 4/9] mfd: intel_soc_pmic_crc: Drop redundant ACPI_PTR() and ifdeffery Andy Shevchenko
2022-07-18 12:23 ` [RESEND][PATCH v1 5/9] mfd: intel_soc_pmic_crc: Convert driver to use ->probe_new() Andy Shevchenko
2022-07-18 12:23 ` [RESEND][PATCH v1 6/9] mfd: intel_soc_pmic_crc: Replace intel_soc_pmic with crystal_cove Andy Shevchenko
2022-07-18 12:23 ` [RESEND][PATCH v1 7/9] mfd: intel_soc_pmic_crc: Update the copyright year Andy Shevchenko
2022-07-18 12:23 ` [RESEND][PATCH v1 8/9] mfd: intel_soc_pmic_bxtwc: Support IRQ chip hierarchy Andy Shevchenko
2022-08-08 15:20 ` Lee Jones [this message]
2022-07-18 12:23 ` [RESEND][PATCH v1 9/9] Revert "mfd: intel_soc_pmic_bxtwc: Support IRQ chip hierarchy" Andy Shevchenko
2022-08-08 15:20 ` Lee Jones
2022-08-08 15:21 ` Lee Jones
2022-08-08 15:35 ` Andy Shevchenko
2022-08-08 15:21 ` [RESEND][PATCH v1 1/9] mfd: intel_soc_pmic_crc: Use devm_regmap_add_irq_chip() Lee Jones
2022-08-08 15:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvEprE7YwuwaMXwL@google.com \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.