From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EF4FC19F2D for ; Tue, 9 Aug 2022 05:11:45 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 140EA3C93FD for ; Tue, 9 Aug 2022 07:11:43 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 291FE3C6D2E for ; Tue, 9 Aug 2022 07:11:30 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 237871A003F4 for ; Tue, 9 Aug 2022 07:11:29 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F20F42025E; Tue, 9 Aug 2022 05:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1660021888; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nDNFpNRBlJa/QvWQRI2W54+2IWDnB4rEU2LfTu9h66s=; b=oGgz2TVUDEODJGw4IWXukV4ecSbOHd+4f+6wQK3x5p1OGHdX4cZgwtzsbk0sctCBCVrr10 FuyksymA62/JwSQKxV9hDxPm5GBkt9bEWQBzx5TSZ4p7tZA3Ippont19N7pyDbOXnH0WOu dOmD8bJ4UghpNt33LmF0C5FwGDILipE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1660021888; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nDNFpNRBlJa/QvWQRI2W54+2IWDnB4rEU2LfTu9h66s=; b=b3JIQbfjXZbImo5u+rKXv1HA2K2+mpswOy6Z9BJcvOvnKHBK7FhBjlGwSDIBbRsB4cTT4e JU9P1It1u79wlLBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AB06B13A9D; Tue, 9 Aug 2022 05:11:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7jESJIDs8WKBQgAAMHmgww (envelope-from ); Tue, 09 Aug 2022 05:11:28 +0000 Date: Tue, 9 Aug 2022 07:11:26 +0200 From: Petr Vorel To: Dylan Jhong Message-ID: References: <20220808110416.2244071-1-dylan@andestech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] fs_bind: Fix incorrect mount option X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: "x5710999x@gmail.com" , "Alan Quey-Liang Kao\(\(\(\(\(\(\(\(\(\(\)" , "ltp@lists.linux.it" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Dylan, > Hi Petr: > Thanks for the review. > >>>>> I wonder why test didn't failed (at least on SUT I tested it). > Some mount command implementations[*1] use getopt_long() to parse mount > options, but getopt_long() seems to treat "--make-share" and "--make-shared" > as the same option. > The error I encounter this time is using busybox's mount command[*2], which > uses strncasecmp() to parse the argements, It will treat "--make-share" and > "--make-shared" as different options. > According to the manual of mount command, "--make-shared" should be the correct > option. > reference: > [*1] https://kernel.googlesource.com/pub/scm/utils/util-linux/util-linux/+/stable/v2.13/mount/mount.c#1816 > [*2] https://github.com/brgl/busybox/blob/master/util-linux/mount.c#L372 > [*3] https://linux.die.net/man/8/mount Thanks for info. Please next time include this in the commit message (useful info, but as I wrote yesterday I already merged your commit). Kind regards, Petr > Best, > Dylan > On Mon, Aug 08, 2022 at 08:53:09PM +0800, Petr Vorel wrote: > > Hi Dylan, > > Reviewed-by: Petr Vorel > > I wonder why test didn't failed (at least on SUT I tested it). > > Kind regards, > > Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp