From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C83C19F2D for ; Tue, 9 Aug 2022 20:19:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232070AbiHIUTx (ORCPT ); Tue, 9 Aug 2022 16:19:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245489AbiHIUTw (ORCPT ); Tue, 9 Aug 2022 16:19:52 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCC04255BE for ; Tue, 9 Aug 2022 13:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=r4N9SdQW/dOC2LPni9a9r8+QuY1I2hw3aE3Gq7lwiqY=; b=m+ wChraoLykeN2Twxl/eUymviSA3vhA6L38feaKGDZM+ke+lbW+Qpr/OoXWywZuBMS5NLWX7Cef1SVU i8efglOD4X13kzr4kOtPR4wVn5pNUK0kdPOf80yK/2cqTR2vruPoG/M/WykexCFV/mkrbY7r8EwWT s+yGXWPlsaZPWqg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oLVhN-00CsMu-V9; Tue, 09 Aug 2022 22:19:33 +0200 Date: Tue, 9 Aug 2022 22:19:33 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 1/4] pinctrl: armada-37xx: Add missing GPIO-only pins Message-ID: References: <20220805122202.23174-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220805122202.23174-1-pali@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Aug 05, 2022 at 02:21:59PM +0200, Pali Rohár wrote: > gpio1_5 and gpio2_2 are GPIO-only pins. Add them into MPP groups table > so they are properly exported as valid pin numbers. > > Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx") > Signed-off-by: Pali Rohár > --- > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > index a140b6bfbfaa..2b44c634ccb5 100644 > --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > @@ -122,6 +122,16 @@ struct armada_37xx_pinctrl { > .funcs = {_func1, _func2} \ > } > > +#define PIN_GRP_GPIO_0(_name, _start, _nr) \ The naming of these macros are a bit odd, but this does not make it any worse. Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6F68C19F2D for ; Tue, 9 Aug 2022 20:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q2opJCQ1rR928XLV4aQ9+f2ZsclS/M+OQ0zE2Zb2K6g=; b=Fhlk7VDqALhGPS ILiAkjzJE6/e3CdYTUZr9LmWAL/DmeTPRCORzpQBd+qvitZS6XpCvTpRTCbBqnWHN55H/K96nc0G1 XKR3O5kKMxw/nskc+/C4nkvP/enNqayagyjkENXy5JKxtmcz2J+HPNxw0HUVsY71WqfaTlqq0b6Td 5aYmhRLmPJFhiOnJDilyuX3lgRrWB1Wjn7LO0ubPNoaatwtvZKXSu7uv1GJqKMk6mkT99GcEzno5D A1cb8P1y43l9fvpXEasQcSTOdU3XEMCyNhhZegBpHHIEiLTjdjlLOjeN59N9gl7oTQ0rgNJbkFzNl IXRiLSqsZvYAmnheKasQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLVhh-006Cyl-6r; Tue, 09 Aug 2022 20:19:53 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLVhY-006Cug-U4 for linux-arm-kernel@lists.infradead.org; Tue, 09 Aug 2022 20:19:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=r4N9SdQW/dOC2LPni9a9r8+QuY1I2hw3aE3Gq7lwiqY=; b=m+ wChraoLykeN2Twxl/eUymviSA3vhA6L38feaKGDZM+ke+lbW+Qpr/OoXWywZuBMS5NLWX7Cef1SVU i8efglOD4X13kzr4kOtPR4wVn5pNUK0kdPOf80yK/2cqTR2vruPoG/M/WykexCFV/mkrbY7r8EwWT s+yGXWPlsaZPWqg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oLVhN-00CsMu-V9; Tue, 09 Aug 2022 22:19:33 +0200 Date: Tue, 9 Aug 2022 22:19:33 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 1/4] pinctrl: armada-37xx: Add missing GPIO-only pins Message-ID: References: <20220805122202.23174-1-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220805122202.23174-1-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220809_131945_250024_E1359C91 X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 05, 2022 at 02:21:59PM +0200, Pali Roh=E1r wrote: > gpio1_5 and gpio2_2 are GPIO-only pins. Add them into MPP groups table > so they are properly exported as valid pin numbers. > = > Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support fo= r Armada 37xx") > Signed-off-by: Pali Roh=E1r > --- > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > = > diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctr= l/mvebu/pinctrl-armada-37xx.c > index a140b6bfbfaa..2b44c634ccb5 100644 > --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > @@ -122,6 +122,16 @@ struct armada_37xx_pinctrl { > .funcs =3D {_func1, _func2} \ > } > = > +#define PIN_GRP_GPIO_0(_name, _start, _nr) \ The naming of these macros are a bit odd, but this does not make it any worse. Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel