From: Lee Jones <lee@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Samuel Ortiz <sameo@linux.intel.com>, Milo Kim <Milo.Kim@ti.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: lp8788: Fix an error handling path in lp8788_irq_init() and lp8788_irq_init()
Date: Wed, 10 Aug 2022 12:17:59 +0100 [thread overview]
Message-ID: <YvOT5wwHtpm3OGP2@google.com> (raw)
In-Reply-To: <bcd5a72c9c1c383dd6324680116426e32737655a.1659261275.git.christophe.jaillet@wanadoo.fr>
On Sun, 31 Jul 2022, Christophe JAILLET wrote:
> In lp8788_irq_init(), if an error occurs after a successful
> irq_domain_add_linear() call, it must be undone by a corresponding
> irq_domain_remove() call.
>
> irq_domain_remove() should also be called in lp8788_irq_exit() for the same
> reason.
>
> Fixes: eea6b7cc53aa ("mfd: Add lp8788 mfd driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/mfd/lp8788-irq.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-08-10 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 9:55 [PATCH 1/2] mfd: lp8788: Fix an error handling path in lp8788_probe() Christophe JAILLET
2022-07-31 9:55 ` [PATCH 2/2] mfd: lp8788: Fix an error handling path in lp8788_irq_init() and lp8788_irq_init() Christophe JAILLET
2022-08-10 11:17 ` Lee Jones [this message]
2022-08-10 11:16 ` [PATCH 1/2] mfd: lp8788: Fix an error handling path in lp8788_probe() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvOT5wwHtpm3OGP2@google.com \
--to=lee@kernel.org \
--cc=Milo.Kim@ti.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.