All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix missing free of machine->kallsyms_filename
Date: Wed, 10 Aug 2022 10:20:07 -0300	[thread overview]
Message-ID: <YvOwhyuJkyDqmR68@kernel.org> (raw)
In-Reply-To: <CAP-5=fWx_evrzai1Q_6FsowHG-V2H5jX58-s5AetJJcG4C0+2g@mail.gmail.com>

Em Tue, Aug 09, 2022 at 09:51:12AM -0700, Ian Rogers escreveu:
> On Tue, Aug 9, 2022 at 6:08 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
> >
> > Add missing free of machine->kallsyms_filename to machine__exit().
> >
> > Fixes: a5367ecb5353 ("perf tools: Automatically use guest kcore_dir if present")
> > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/util/machine.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> > index facc13fbf16e..2a16cae28407 100644
> > --- a/tools/perf/util/machine.c
> > +++ b/tools/perf/util/machine.c
> > @@ -236,6 +236,7 @@ void machine__exit(struct machine *machine)
> >         zfree(&machine->root_dir);
> >         zfree(&machine->mmap_name);
> >         zfree(&machine->current_tid);
> > +       zfree(&machine->kallsyms_filename);
> >
> >         for (i = 0; i < THREADS__TABLE_SIZE; i++) {
> >                 struct threads *threads = &machine->threads[i];
> > --
> > 2.25.1
> >

-- 

- Arnaldo

      reply	other threads:[~2022-08-10 13:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 13:07 [PATCH] perf tools: Fix missing free of machine->kallsyms_filename Adrian Hunter
2022-08-09 16:51 ` Ian Rogers
2022-08-10 13:20   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvOwhyuJkyDqmR68@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.