All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Lee Jones <lee.jones@linaro.org>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>, Greg KH <greg@kroah.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	ksummit@lists.linux.dev
Subject: Re: Validating MAINTAINERS entries?
Date: Wed, 10 Aug 2022 16:29:02 +0100	[thread overview]
Message-ID: <YvPOvuEOgdyTnizZ@google.com> (raw)
In-Reply-To: <CAL_JsqJf4Foih7Z8xXjfdeONwH5wCMRYSU8Fzta_F49q+Bp4MA@mail.gmail.com>

On Wed, 10 Aug 2022, Rob Herring wrote:

> On Wed, Aug 10, 2022 at 7:25 AM Lee Jones <lee@kernel.org> wrote:
> >
> > On Wed, 10 Aug 2022, Mark Brown wrote:
> >
> > > On Wed, Aug 10, 2022 at 03:04:50PM +0300, Dan Carpenter wrote:
> > > > On Wed, Aug 10, 2022 at 12:50:50PM +0100, Lee Jones wrote:
> > >
> > > > > I am presently plagued with reviews for lots of files that I've
> > > > > touched over the years.  Even if the changes were trivial.
> 
> After your W=1 and kerneldoc fixes, you're screwed. ;)

Yes, and the tragic thing is, I still have aspirations to go finish that!

> > > > > Or is this just an education point?
> > >
> > > > Education is not the answer.
> 
> Yes. I'm convinced there is no way to solve these problems on the
> sender side. I see plenty of cases of not running get_maintainers.pl.
> You've got to filter out what you want on your end. And lei is great
> for that.
> 
> > > > We've got thousands of devs and no one can keep track of everyone and
> > > > their motives.
> > >
> > > I think the issue there is more that if someone sent a drive by patch to
> > > some driver they'll start showing up in the git history and often get
> > > CCed on future changes going forwards, which can then result in getting
> > > copied into further postings done by copying from prior postings.  That
> > > does feel somewhat tractable to education, at least in the early stages.
> >
> > How about default tooling values, get_maintainer.pl in this case?
> >
> > I tend to over-ride this default to 75% to avoid the aforementioned:
> >
> >   --git-min-percent => minimum percentage of commits required (default: 5)
> >
> > 5 is not a lot of percent for seldomly touched source files.
> 
> Send a patch. I would also bump --git-min-signatures from 1.

I can do that.  Fair warning, it won't be until around mid-cycle.

-- 
Lee Jones [李琼斯]

  parent reply	other threads:[~2022-08-10 15:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10  0:13 Validating MAINTAINERS entries? Stephen Hemminger
2022-08-10  8:23 ` Greg KH
2022-08-10  8:26 ` Dan Carpenter
2022-08-10  8:36   ` Greg KH
2022-08-10  8:55     ` Lukas Bulwahn
2022-08-10  9:10       ` Dan Carpenter
2022-08-10 11:50       ` Lee Jones
2022-08-10 12:04         ` Dan Carpenter
2022-08-10 12:12           ` Serge E. Hallyn
2022-08-10 12:50           ` Mark Brown
2022-08-10 13:25             ` Lee Jones
2022-08-10 13:54               ` Rob Herring
2022-08-10 14:01                 ` Mark Brown
2022-08-10 14:19                   ` Konstantin Ryabitsev
2022-08-10 14:20                   ` Rob Herring
2022-08-10 14:35                     ` Mark Brown
2022-08-11 12:36                       ` Sudip Mukherjee
2022-08-10 15:29                 ` Lee Jones [this message]
2022-08-11  8:35             ` Geert Uytterhoeven
2022-08-11  8:42               ` Christoph Hellwig
2022-08-10  8:46   ` Lukas Bulwahn
2022-08-10  8:42 ` Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvPOvuEOgdyTnizZ@google.com \
    --to=lee@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=greg@kroah.com \
    --cc=ksummit@lists.linux.dev \
    --cc=lee.jones@linaro.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=robherring2@gmail.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.