From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14D70C25B07 for ; Wed, 10 Aug 2022 19:34:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 800044DA6F; Wed, 10 Aug 2022 15:34:12 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@linux.dev Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LyFFjXc+xKtT; Wed, 10 Aug 2022 15:34:11 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0D4CA4DA69; Wed, 10 Aug 2022 15:34:11 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BC5564DA55 for ; Wed, 10 Aug 2022 15:34:09 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IW5pQHmhXB70 for ; Wed, 10 Aug 2022 15:34:08 -0400 (EDT) Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 60B9D4DA53 for ; Wed, 10 Aug 2022 15:34:08 -0400 (EDT) Date: Wed, 10 Aug 2022 14:33:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1660160047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xd7ZEh3Cai7T9+89O7KBFEDHECO3gMJG4kN2ocTFX7A=; b=gZ45Svi4/xPi8Uqm/3lqwxOfKntmq36LjsWKSmUW6nYlWib/04Y6vZ31GUKn3YNO8cljdM EQzpyHEIhidWwAm6OXLz4+hBTEHeQdL2c1GgIGcj6VZ5bhoUKGHdzJQhwwImYP4jWLyL0C wZqU6VogFnXuXNTqPRwlJKPkEb7vfro= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Ricardo Koller Subject: Re: [PATCH 0/9] KVM: arm64: PMU: Fixing chained events, and PMUv3p5 support Message-ID: References: <20220805135813.2102034-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Cc: kernel-team@android.com, kvm@vger.kernel.org, Marc Zyngier , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgUmljYXJkbywKCk9uIFdlZCwgQXVnIDEwLCAyMDIyIGF0IDExOjQ2OjIyQU0gLTA3MDAsIFJp Y2FyZG8gS29sbGVyIHdyb3RlOgo+IE9uIEZyaSwgQXVnIDA1LCAyMDIyIGF0IDAyOjU4OjA0UE0g KzAxMDAsIE1hcmMgWnluZ2llciB3cm90ZToKPiA+IFJpY2FyZG8gcmVjZW50bHkgcmVwb3J0ZWRb MV0gdGhhdCBvdXIgUE1VIGVtdWxhdGlvbiB3YXMgYnVzdGVkIHdoZW4gaXQKPiA+IGNvbWVzIHRv IGNoYWluZWQgZXZlbnRzLCBhcyB3ZSBjYW5ub3QgZXhwb3NlIHRoZSBvdmVyZmxvdyBvbiBhIDMy Yml0Cj4gPiBib3VuZGFyeSAod2hpY2ggdGhlIGFyY2hpdGVjdHVyZSByZXF1aXJlcykuCj4gPiAK PiA+IFRoaXMgc2VyaWVzIGFpbXMgYXQgZml4aW5nIHRoaXMgKGJ5IGRlbGV0aW5nIGEgbG90IG9m IGNvZGUpLCBhbmQgYXMgYQo+ID4gYm9udXMgYWRkcyBzdXBwb3J0IGZvciBQTVV2M3A1LCBhcyB0 aGlzIHJlcXVpcmVzIHVzIHRvIGZpeCBhIGZldyBtb3JlCj4gPiB0aGluZ3MuCj4gPiAKPiA+IFRl c3RlZCBvbiBBNTMgKFBNVXYzKSBhbmQgRlZQIChQTVV2M3A1KS4KPiA+IAo+ID4gWzFdIGh0dHBz Oi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMjA4MDUwMDQxMzkuOTkwNTMxLTEtcmljYXJrb2xAZ29v Z2xlLmNvbQo+ID4gCj4gPiBNYXJjIFp5bmdpZXIgKDkpOgo+ID4gICBLVk06IGFybTY0OiBQTVU6 IEFsaWduIGNoYWluZWQgY291bnRlciBpbXBsZW1lbnRhdGlvbiB3aXRoCj4gPiAgICAgYXJjaGl0 ZWN0dXJlIHBzZXVkb2NvZGUKPiA+ICAgS1ZNOiBhcm02NDogUE1VOiBEaXN0aW5ndWlzaCBiZXR3 ZWVuIDY0Yml0IGNvdW50ZXIgYW5kIDY0Yml0IG92ZXJmbG93Cj4gPiAgIEtWTTogYXJtNjQ6IFBN VTogT25seSBuYXJyb3cgY291bnRlcnMgdGhhdCBhcmUgbm90IDY0Yml0IHdpZGUKPiA+ICAgS1ZN OiBhcm02NDogUE1VOiBBZGQgY291bnRlcl9pbmRleF90b18qcmVnKCkgaGVscGVycwo+ID4gICBL Vk06IGFybTY0OiBQTVU6IFNpbXBsaWZ5IHNldHRpbmcgYSBjb3VudGVyIHRvIGEgc3BlY2lmaWMg dmFsdWUKPiA+ICAgS1ZNOiBhcm02NDogUE1VOiBNb3ZlIHRoZSBJRF9BQTY0REZSMF9FTDEuUE1V dmVyIGxpbWl0IHRvIFZNIGNyZWF0aW9uCj4gPiAgIEtWTTogYXJtNjQ6IFBNVTogQWxldmVuIElE X0FBNjRERlIwX0VMMS5QTVV2ZXIgdG8gYmUgc2V0IGZyb20gdXNlcnNwYWNlCj4gPiAgIEtWTTog YXJtNjQ6IFBNVTogSW1wbGVtZW50IFBNVXYzcDUgbG9uZyBjb3VudGVyIHN1cHBvcnQKPiA+ICAg S1ZNOiBhcm02NDogUE1VOiBBbGV2ZW4gUE1VdjNwNSB0byBiZSBleHBvc2VkIHRvIHRoZSBndWVz dAo+ID4gCj4gPiAgYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5oIHwgICAxICsKPiA+ ICBhcmNoL2FybTY0L2t2bS9hcm0uYyAgICAgICAgICAgICAgfCAgIDYgKwo+ID4gIGFyY2gvYXJt NjQva3ZtL3BtdS1lbXVsLmMgICAgICAgICB8IDM3MiArKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLS0KPiA+ICBhcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jICAgICAgICAgfCAgNjUgKysrKyst Cj4gPiAgaW5jbHVkZS9rdm0vYXJtX3BtdS5oICAgICAgICAgICAgIHwgIDE2ICstCj4gPiAgNSBm aWxlcyBjaGFuZ2VkLCAyMDggaW5zZXJ0aW9ucygrKSwgMjUyIGRlbGV0aW9ucygtKQo+ID4gCj4g PiAtLSAKPiA+IDIuMzQuMQo+ID4gCj4gCj4gSGkgTWFyYywKPiAKPiBUaGVyZSBpcyBvbmUgZXh0 cmEgcG90ZW50aWFsIGlzc3VlIHdpdGggZXhwb3NpbmcgUE1VdjNwNS4gSSBzZWUgdGhpcwo+IHdl aXJkIGJlaGF2aW9yIHdoZW4gZG9pbmcgcGFzc3Rocm91Z2ggKCJiYXJlIG1ldGFsIikgb24gdGhl IGZhc3QtbW9kZWwKPiBjb25maWd1cmVkIHRvIGVtdWxhdGUgUE1VdjNwNTogdGhlIFs2MzozMl0g aGFsZiBvZiB0aGUgY291bnRlcnMKPiBvdmVyZmxvd2luZyBhdCAzMi1iaXRzIGlzIHN0aWxsIGlu Y3JlbWVudGVkLgo+IAo+ICAgRmFzdCBtb2RlbCAtIEFSTXY4LjU6Cj4gICAgCj4gCUFzc3VtaW5n IHRoZSBpbml0aWFsIHN0YXRlIGlzIGV2ZW49MHhGRkZGRkZGRiBhbmQgb2RkPTB4MCwKPiAJaW5j cmVtZW50aW5nIHRoZSBldmVuIGNvdW50ZXIgbGVhZHMgdG86Cj4gCj4gCTB4MDAwMDAwMDFfMDAw MDAwMDAJMHgwMDAwMDAwMF8wMDAwMDAwMQkJMHgxCj4gCWV2ZW4gY291bnRlcgkJb2RkIGNvdW50 ZXIJCQlQTU9WU0VUCj4gCj4gCUFzc3VtaW5nIHRoZSBpbml0aWFsIHN0YXRlIGlzIGV2ZW49MHhG RkZGRkZGRiBhbmQgb2RkPTB4RkZGRkZGRkYsCj4gCWluY3JlbWVudGluZyB0aGUgZXZlbiBjb3Vu dGVyIGxlYWRzIHRvOgo+IAo+IAkweDAwMDAwMDAxXzAwMDAwMDAwCTB4MDAwMDAwMDFfMDAwMDAw MDAJCTB4Mwo+IAlldmVuIGNvdW50ZXIJCW9kZCBjb3VudGVyCQkJUE1PVlNFVAoKVGhpcyBpcyB0 byBiZSBleHBlY3RlZCwgYWN0dWFsbHkuIFBNVXY4cDUgY291bnRlcnMgYXJlIGFsd2F5cyA2NCBi aXQsCnJlZ2FyZGxlc3Mgb2YgdGhlIGNvbmZpZ3VyZWQgb3ZlcmZsb3cuCgpEREkgMDQ4N0ggRDgu MyBCZWhhdmlvciBvbiBvdmVyZmxvdwoKICBJZiBGRUFUX1BNVXYzcDUgaXMgaW1wbGVtZW50ZWQs IDY0LWJpdCBldmVudCBjb3VudGVycyBhcmUgaW1wbGVtZW50ZWQsCiAgSERDUi5IUE1OIGlzIG5v dCAwLCBhbmQgZWl0aGVyIG4gaXMgaW4gdGhlIHJhbmdlIFswIC4uIChIRENSLkhQTU4tMSldCiAg b3IgRUwyIGlzIG5vdCBpbXBsZW1lbnRlZCwgdGhlbiBldmVudCBjb3VudGVyIG92ZXJmbG93IGlz IGNvbmZpZ3VyZWQKICBieSBQTUNSLkxQOgoKICDigJQgV2hlbiBQTUNSLkxQIGlzIHNldCB0byAw LCBpZiBpbmNyZW1lbnRpbmcgUE1FVkNOVFI8bj4gY2F1c2VzIGFuIHVuc2lnbmVkCiAgICBvdmVy ZmxvdyBvZiBiaXRzIFszMTowXSBvZiB0aGUgZXZlbnQgY291bnRlciwgdGhlIFBFIHNldHMgUE1P VlNDTFJbbl0gdG8gMS4KICDigJQgV2hlbiBQTUNSLkxQIGlzIHNldCB0byAxLCBpZiBpbmNyZW1l bnRpbmcgUE1FVkNOVFI8bj4gY2F1c2VzIGFuIHVuc2lnbmVkCiAgICBvdmVyZmxvdyBvZiBiaXRz IFs2MzowXSBvZiB0aGUgZXZlbnQgY291bnRlciwgdGhlIFBFIHNldHMgUE1PVlNDTFJbbl0gdG8g MS4KCiAgWy4uLl0KCiAgRm9yIGFsbCA2NC1iaXQgY291bnRlcnMsIGluY3JlbWVudGluZyB0aGUg Y291bnRlciBpcyB0aGUgc2FtZSB3aGV0aGVyIGFuCiAgdW5zaWduZWQgb3ZlcmZsb3cgb2NjdXJz IGF0IFszMTowXSBvciBbNjM6MF0uIElmIHRoZSBjb3VudGVyIGluY3JlbWVudHMKICBmb3IgYW4g ZXZlbnQsIGJpdHMgWzYzOjBdIGFyZSBhbHdheXMgaW5jcmVtZW50ZWQuCgpEbyB5b3Ugc2VlIHRo aXMgc2FtZSAoZXhwZWN0ZWQpIGZhaWx1cmUgdy8gTWFyYydzIHNlcmllcz8KCi0tClRoYW5rcywK T2xpdmVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2 bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xp c3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F467C00140 for ; Wed, 10 Aug 2022 19:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MRiJ9YqW8gmfPxiH0IOfsVJkp69NysgG5ooT4O+b+Yo=; b=4F/89CQsC+YwKs Q7NJ759BOjOiWxKOv/S9HEAZeh8doDVP7knMiMtmMIc9elVnbsCiHzCuDyw9BfBb31FqGDymZvxao 59vq3BWFqu9gYpS83bFnG5kenis+SRsPZ6QGUNERsn7lXwfByvtc2ZqeHy3SpcuqwWf9C/JC9tkDL dkgfLorlCKzGExNld8RlW+jN1AogxU2cNiB5z6qNFREpr07m4LhDXeQgs30Zw68l9qfk8804cBjel 02Id74SIoTtUcp02gVNyKTQanqoZS96tOGWAy2dPuNKYVmj2WiyfwWe4eKYxQPLjCRO2hf440q6G2 1qGSH3vz7VPQHcK8jgEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLrTW-00EEQ1-IG; Wed, 10 Aug 2022 19:34:42 +0000 Received: from out1.migadu.com ([91.121.223.63]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLrT4-00EE1D-Ig for linux-arm-kernel@lists.infradead.org; Wed, 10 Aug 2022 19:34:16 +0000 Date: Wed, 10 Aug 2022 14:33:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1660160047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xd7ZEh3Cai7T9+89O7KBFEDHECO3gMJG4kN2ocTFX7A=; b=gZ45Svi4/xPi8Uqm/3lqwxOfKntmq36LjsWKSmUW6nYlWib/04Y6vZ31GUKn3YNO8cljdM EQzpyHEIhidWwAm6OXLz4+hBTEHeQdL2c1GgIGcj6VZ5bhoUKGHdzJQhwwImYP4jWLyL0C wZqU6VogFnXuXNTqPRwlJKPkEb7vfro= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Ricardo Koller Cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH 0/9] KVM: arm64: PMU: Fixing chained events, and PMUv3p5 support Message-ID: References: <20220805135813.2102034-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220810_123414_965514_1C0B31B6 X-CRM114-Status: GOOD ( 23.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUmljYXJkbywKCk9uIFdlZCwgQXVnIDEwLCAyMDIyIGF0IDExOjQ2OjIyQU0gLTA3MDAsIFJp Y2FyZG8gS29sbGVyIHdyb3RlOgo+IE9uIEZyaSwgQXVnIDA1LCAyMDIyIGF0IDAyOjU4OjA0UE0g KzAxMDAsIE1hcmMgWnluZ2llciB3cm90ZToKPiA+IFJpY2FyZG8gcmVjZW50bHkgcmVwb3J0ZWRb MV0gdGhhdCBvdXIgUE1VIGVtdWxhdGlvbiB3YXMgYnVzdGVkIHdoZW4gaXQKPiA+IGNvbWVzIHRv IGNoYWluZWQgZXZlbnRzLCBhcyB3ZSBjYW5ub3QgZXhwb3NlIHRoZSBvdmVyZmxvdyBvbiBhIDMy Yml0Cj4gPiBib3VuZGFyeSAod2hpY2ggdGhlIGFyY2hpdGVjdHVyZSByZXF1aXJlcykuCj4gPiAK PiA+IFRoaXMgc2VyaWVzIGFpbXMgYXQgZml4aW5nIHRoaXMgKGJ5IGRlbGV0aW5nIGEgbG90IG9m IGNvZGUpLCBhbmQgYXMgYQo+ID4gYm9udXMgYWRkcyBzdXBwb3J0IGZvciBQTVV2M3A1LCBhcyB0 aGlzIHJlcXVpcmVzIHVzIHRvIGZpeCBhIGZldyBtb3JlCj4gPiB0aGluZ3MuCj4gPiAKPiA+IFRl c3RlZCBvbiBBNTMgKFBNVXYzKSBhbmQgRlZQIChQTVV2M3A1KS4KPiA+IAo+ID4gWzFdIGh0dHBz Oi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMjA4MDUwMDQxMzkuOTkwNTMxLTEtcmljYXJrb2xAZ29v Z2xlLmNvbQo+ID4gCj4gPiBNYXJjIFp5bmdpZXIgKDkpOgo+ID4gICBLVk06IGFybTY0OiBQTVU6 IEFsaWduIGNoYWluZWQgY291bnRlciBpbXBsZW1lbnRhdGlvbiB3aXRoCj4gPiAgICAgYXJjaGl0 ZWN0dXJlIHBzZXVkb2NvZGUKPiA+ICAgS1ZNOiBhcm02NDogUE1VOiBEaXN0aW5ndWlzaCBiZXR3 ZWVuIDY0Yml0IGNvdW50ZXIgYW5kIDY0Yml0IG92ZXJmbG93Cj4gPiAgIEtWTTogYXJtNjQ6IFBN VTogT25seSBuYXJyb3cgY291bnRlcnMgdGhhdCBhcmUgbm90IDY0Yml0IHdpZGUKPiA+ICAgS1ZN OiBhcm02NDogUE1VOiBBZGQgY291bnRlcl9pbmRleF90b18qcmVnKCkgaGVscGVycwo+ID4gICBL Vk06IGFybTY0OiBQTVU6IFNpbXBsaWZ5IHNldHRpbmcgYSBjb3VudGVyIHRvIGEgc3BlY2lmaWMg dmFsdWUKPiA+ICAgS1ZNOiBhcm02NDogUE1VOiBNb3ZlIHRoZSBJRF9BQTY0REZSMF9FTDEuUE1V dmVyIGxpbWl0IHRvIFZNIGNyZWF0aW9uCj4gPiAgIEtWTTogYXJtNjQ6IFBNVTogQWxldmVuIElE X0FBNjRERlIwX0VMMS5QTVV2ZXIgdG8gYmUgc2V0IGZyb20gdXNlcnNwYWNlCj4gPiAgIEtWTTog YXJtNjQ6IFBNVTogSW1wbGVtZW50IFBNVXYzcDUgbG9uZyBjb3VudGVyIHN1cHBvcnQKPiA+ICAg S1ZNOiBhcm02NDogUE1VOiBBbGV2ZW4gUE1VdjNwNSB0byBiZSBleHBvc2VkIHRvIHRoZSBndWVz dAo+ID4gCj4gPiAgYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5oIHwgICAxICsKPiA+ ICBhcmNoL2FybTY0L2t2bS9hcm0uYyAgICAgICAgICAgICAgfCAgIDYgKwo+ID4gIGFyY2gvYXJt NjQva3ZtL3BtdS1lbXVsLmMgICAgICAgICB8IDM3MiArKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLS0KPiA+ICBhcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jICAgICAgICAgfCAgNjUgKysrKyst Cj4gPiAgaW5jbHVkZS9rdm0vYXJtX3BtdS5oICAgICAgICAgICAgIHwgIDE2ICstCj4gPiAgNSBm aWxlcyBjaGFuZ2VkLCAyMDggaW5zZXJ0aW9ucygrKSwgMjUyIGRlbGV0aW9ucygtKQo+ID4gCj4g PiAtLSAKPiA+IDIuMzQuMQo+ID4gCj4gCj4gSGkgTWFyYywKPiAKPiBUaGVyZSBpcyBvbmUgZXh0 cmEgcG90ZW50aWFsIGlzc3VlIHdpdGggZXhwb3NpbmcgUE1VdjNwNS4gSSBzZWUgdGhpcwo+IHdl aXJkIGJlaGF2aW9yIHdoZW4gZG9pbmcgcGFzc3Rocm91Z2ggKCJiYXJlIG1ldGFsIikgb24gdGhl IGZhc3QtbW9kZWwKPiBjb25maWd1cmVkIHRvIGVtdWxhdGUgUE1VdjNwNTogdGhlIFs2MzozMl0g aGFsZiBvZiB0aGUgY291bnRlcnMKPiBvdmVyZmxvd2luZyBhdCAzMi1iaXRzIGlzIHN0aWxsIGlu Y3JlbWVudGVkLgo+IAo+ICAgRmFzdCBtb2RlbCAtIEFSTXY4LjU6Cj4gICAgCj4gCUFzc3VtaW5n IHRoZSBpbml0aWFsIHN0YXRlIGlzIGV2ZW49MHhGRkZGRkZGRiBhbmQgb2RkPTB4MCwKPiAJaW5j cmVtZW50aW5nIHRoZSBldmVuIGNvdW50ZXIgbGVhZHMgdG86Cj4gCj4gCTB4MDAwMDAwMDFfMDAw MDAwMDAJMHgwMDAwMDAwMF8wMDAwMDAwMQkJMHgxCj4gCWV2ZW4gY291bnRlcgkJb2RkIGNvdW50 ZXIJCQlQTU9WU0VUCj4gCj4gCUFzc3VtaW5nIHRoZSBpbml0aWFsIHN0YXRlIGlzIGV2ZW49MHhG RkZGRkZGRiBhbmQgb2RkPTB4RkZGRkZGRkYsCj4gCWluY3JlbWVudGluZyB0aGUgZXZlbiBjb3Vu dGVyIGxlYWRzIHRvOgo+IAo+IAkweDAwMDAwMDAxXzAwMDAwMDAwCTB4MDAwMDAwMDFfMDAwMDAw MDAJCTB4Mwo+IAlldmVuIGNvdW50ZXIJCW9kZCBjb3VudGVyCQkJUE1PVlNFVAoKVGhpcyBpcyB0 byBiZSBleHBlY3RlZCwgYWN0dWFsbHkuIFBNVXY4cDUgY291bnRlcnMgYXJlIGFsd2F5cyA2NCBi aXQsCnJlZ2FyZGxlc3Mgb2YgdGhlIGNvbmZpZ3VyZWQgb3ZlcmZsb3cuCgpEREkgMDQ4N0ggRDgu MyBCZWhhdmlvciBvbiBvdmVyZmxvdwoKICBJZiBGRUFUX1BNVXYzcDUgaXMgaW1wbGVtZW50ZWQs IDY0LWJpdCBldmVudCBjb3VudGVycyBhcmUgaW1wbGVtZW50ZWQsCiAgSERDUi5IUE1OIGlzIG5v dCAwLCBhbmQgZWl0aGVyIG4gaXMgaW4gdGhlIHJhbmdlIFswIC4uIChIRENSLkhQTU4tMSldCiAg b3IgRUwyIGlzIG5vdCBpbXBsZW1lbnRlZCwgdGhlbiBldmVudCBjb3VudGVyIG92ZXJmbG93IGlz IGNvbmZpZ3VyZWQKICBieSBQTUNSLkxQOgoKICDigJQgV2hlbiBQTUNSLkxQIGlzIHNldCB0byAw LCBpZiBpbmNyZW1lbnRpbmcgUE1FVkNOVFI8bj4gY2F1c2VzIGFuIHVuc2lnbmVkCiAgICBvdmVy ZmxvdyBvZiBiaXRzIFszMTowXSBvZiB0aGUgZXZlbnQgY291bnRlciwgdGhlIFBFIHNldHMgUE1P VlNDTFJbbl0gdG8gMS4KICDigJQgV2hlbiBQTUNSLkxQIGlzIHNldCB0byAxLCBpZiBpbmNyZW1l bnRpbmcgUE1FVkNOVFI8bj4gY2F1c2VzIGFuIHVuc2lnbmVkCiAgICBvdmVyZmxvdyBvZiBiaXRz IFs2MzowXSBvZiB0aGUgZXZlbnQgY291bnRlciwgdGhlIFBFIHNldHMgUE1PVlNDTFJbbl0gdG8g MS4KCiAgWy4uLl0KCiAgRm9yIGFsbCA2NC1iaXQgY291bnRlcnMsIGluY3JlbWVudGluZyB0aGUg Y291bnRlciBpcyB0aGUgc2FtZSB3aGV0aGVyIGFuCiAgdW5zaWduZWQgb3ZlcmZsb3cgb2NjdXJz IGF0IFszMTowXSBvciBbNjM6MF0uIElmIHRoZSBjb3VudGVyIGluY3JlbWVudHMKICBmb3IgYW4g ZXZlbnQsIGJpdHMgWzYzOjBdIGFyZSBhbHdheXMgaW5jcmVtZW50ZWQuCgpEbyB5b3Ugc2VlIHRo aXMgc2FtZSAoZXhwZWN0ZWQpIGZhaWx1cmUgdy8gTWFyYydzIHNlcmllcz8KCi0tClRoYW5rcywK T2xpdmVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82C48C00140 for ; Wed, 10 Aug 2022 19:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233201AbiHJTeK (ORCPT ); Wed, 10 Aug 2022 15:34:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232960AbiHJTeJ (ORCPT ); Wed, 10 Aug 2022 15:34:09 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5C887695F for ; Wed, 10 Aug 2022 12:34:08 -0700 (PDT) Date: Wed, 10 Aug 2022 14:33:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1660160047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xd7ZEh3Cai7T9+89O7KBFEDHECO3gMJG4kN2ocTFX7A=; b=gZ45Svi4/xPi8Uqm/3lqwxOfKntmq36LjsWKSmUW6nYlWib/04Y6vZ31GUKn3YNO8cljdM EQzpyHEIhidWwAm6OXLz4+hBTEHeQdL2c1GgIGcj6VZ5bhoUKGHdzJQhwwImYP4jWLyL0C wZqU6VogFnXuXNTqPRwlJKPkEb7vfro= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Ricardo Koller Cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH 0/9] KVM: arm64: PMU: Fixing chained events, and PMUv3p5 support Message-ID: References: <20220805135813.2102034-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Ricardo, On Wed, Aug 10, 2022 at 11:46:22AM -0700, Ricardo Koller wrote: > On Fri, Aug 05, 2022 at 02:58:04PM +0100, Marc Zyngier wrote: > > Ricardo recently reported[1] that our PMU emulation was busted when it > > comes to chained events, as we cannot expose the overflow on a 32bit > > boundary (which the architecture requires). > > > > This series aims at fixing this (by deleting a lot of code), and as a > > bonus adds support for PMUv3p5, as this requires us to fix a few more > > things. > > > > Tested on A53 (PMUv3) and FVP (PMUv3p5). > > > > [1] https://lore.kernel.org/r/20220805004139.990531-1-ricarkol@google.com > > > > Marc Zyngier (9): > > KVM: arm64: PMU: Align chained counter implementation with > > architecture pseudocode > > KVM: arm64: PMU: Distinguish between 64bit counter and 64bit overflow > > KVM: arm64: PMU: Only narrow counters that are not 64bit wide > > KVM: arm64: PMU: Add counter_index_to_*reg() helpers > > KVM: arm64: PMU: Simplify setting a counter to a specific value > > KVM: arm64: PMU: Move the ID_AA64DFR0_EL1.PMUver limit to VM creation > > KVM: arm64: PMU: Aleven ID_AA64DFR0_EL1.PMUver to be set from userspace > > KVM: arm64: PMU: Implement PMUv3p5 long counter support > > KVM: arm64: PMU: Aleven PMUv3p5 to be exposed to the guest > > > > arch/arm64/include/asm/kvm_host.h | 1 + > > arch/arm64/kvm/arm.c | 6 + > > arch/arm64/kvm/pmu-emul.c | 372 ++++++++++-------------------- > > arch/arm64/kvm/sys_regs.c | 65 +++++- > > include/kvm/arm_pmu.h | 16 +- > > 5 files changed, 208 insertions(+), 252 deletions(-) > > > > -- > > 2.34.1 > > > > Hi Marc, > > There is one extra potential issue with exposing PMUv3p5. I see this > weird behavior when doing passthrough ("bare metal") on the fast-model > configured to emulate PMUv3p5: the [63:32] half of the counters > overflowing at 32-bits is still incremented. > > Fast model - ARMv8.5: > > Assuming the initial state is even=0xFFFFFFFF and odd=0x0, > incrementing the even counter leads to: > > 0x00000001_00000000 0x00000000_00000001 0x1 > even counter odd counter PMOVSET > > Assuming the initial state is even=0xFFFFFFFF and odd=0xFFFFFFFF, > incrementing the even counter leads to: > > 0x00000001_00000000 0x00000001_00000000 0x3 > even counter odd counter PMOVSET This is to be expected, actually. PMUv8p5 counters are always 64 bit, regardless of the configured overflow. DDI 0487H D8.3 Behavior on overflow If FEAT_PMUv3p5 is implemented, 64-bit event counters are implemented, HDCR.HPMN is not 0, and either n is in the range [0 .. (HDCR.HPMN-1)] or EL2 is not implemented, then event counter overflow is configured by PMCR.LP: — When PMCR.LP is set to 0, if incrementing PMEVCNTR causes an unsigned overflow of bits [31:0] of the event counter, the PE sets PMOVSCLR[n] to 1. — When PMCR.LP is set to 1, if incrementing PMEVCNTR causes an unsigned overflow of bits [63:0] of the event counter, the PE sets PMOVSCLR[n] to 1. [...] For all 64-bit counters, incrementing the counter is the same whether an unsigned overflow occurs at [31:0] or [63:0]. If the counter increments for an event, bits [63:0] are always incremented. Do you see this same (expected) failure w/ Marc's series? -- Thanks, Oliver