All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH] KVM: VMX: Heed the 'msr' argument in msr_write_intercepted()
Date: Wed, 10 Aug 2022 21:50:34 +0000	[thread overview]
Message-ID: <YvQoKgquagMadG85@google.com> (raw)
In-Reply-To: <20220810213050.2655000-1-jmattson@google.com>

On Wed, Aug 10, 2022, Jim Mattson wrote:
> Regardless of the 'msr' argument passed to the VMX version of
> msr_write_intercepted(), the function always checks to see if a
> specific MSR (IA32_SPEC_CTRL) is intercepted for write.  This behavior
> seems unintentional and unexpected.
> 
> Modify the function so that it checks to see if the provided 'msr'
> index is intercepted for write.
> 
> Fixes: 67f4b9969c30 ("KVM: nVMX: Handle dynamic MSR intercept toggling")
> Cc: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---

I could have sworn this got fixed already.  Or maybe Aaron just pointed it out
off-list?

Reviewed-by: Sean Christopherson <seanjc@google.com>

  reply	other threads:[~2022-08-10 21:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10 21:30 [PATCH] KVM: VMX: Heed the 'msr' argument in msr_write_intercepted() Jim Mattson
2022-08-10 21:50 ` Sean Christopherson [this message]
2022-08-12  7:57 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvQoKgquagMadG85@google.com \
    --to=seanjc@google.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.