Re: [Buildroot] [PATCH 0/2] fix elf2flt on m68k

[Niklas Cassel via buildroot <buildroot@buildroot.org>]

On Thu, Aug 11, 2022 at 01:38:33AM +0200, Waldemar Brodkorb wrote:
> Hi Niklas,
> 
> it still fails for qemu_xtensa_lx60_nommu_defconfig with:
> /home/wbx/buildroot/output/host/xtensa-buildroot-uclinux-uclibc/bin/elf2flt:
> ERROR: text=0x69904 overlaps data=0x569a0 ?

This is because of the same bad upstream elf2flt commit
ba379d08bb78 ("elf2flt: fix for segfault on some ARM ELFs"),
which fixed segfaults on ARM, but seems to have introduced
segfaults on some previously working archs.

The solution is to also include xtensa in my patch:

+  if ((s->flags & (SEC_DATA | SEC_READONLY | SEC_RELOC)) ==
+      (SEC_DATA | SEC_READONLY | SEC_RELOC)) {
+#if defined(TARGET_m68k) || defined(TARGET_riscv64) || defined(TARGET_xtensa)
+    if (!strcmp(".eh_frame", s->name))
+      return false;
+#endif
+    return true;
+  }
+  return false;

Let me send a v2 with this shortly.

However, if we keep adding additional, then we might
eventually be able to change it into a:

+#if defined (TARGET_arm)
+#else
+#endif


Kind regards,
Niklas

> 
> best regards
>  Waldemar
> 
> Niklas Cassel via buildroot wrote,
> 
> > Hello buildroot folks,
> > 
> > This series fixes a segfault at link time on m68k.
> > 
> > With this series, we have bootable m68k and riscv64.
> > 
> > (riscv64 was booting with the previous patch, but we
> > were simply lucky that we didn't observe the same
> > segfault there as well.)
> > 
> > 
> > Kind regards,
> > Niklas
> > 
> > Niklas Cassel (2):
> >   package/elf2flt: remove broken patch
> >   package/elf2flt: add another .eh_frame section handling patch
> > 
> >  ...3-elf2flt-add-riscv-64-bits-support.patch} |  0
> >  ...f2flt-fix-.eh_frame-section-handling.patch | 73 ------------------
> >  ...2flt-create-a-common-helper-function.patch | 76 +++++++++++++++++++
> >  ...l-error-regression-on-m68k-and-riscv.patch | 72 ++++++++++++++++++
> >  4 files changed, 148 insertions(+), 73 deletions(-)
> >  rename package/elf2flt/{0004-elf2flt-add-riscv-64-bits-support.patch => 0003-elf2flt-add-riscv-64-bits-support.patch} (100%)
> >  delete mode 100644 package/elf2flt/0003-elf2flt-fix-.eh_frame-section-handling.patch
> >  create mode 100644 package/elf2flt/0004-elf2flt-create-a-common-helper-function.patch
> >  create mode 100644 package/elf2flt/0005-elf2flt-fix-fatal-error-regression-on-m68k-and-riscv.patch
> > 
> > -- 
> > 2.37.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> > 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot