From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs_repair: retain superblock buffer to avoid write hook deadlock
Date: Thu, 11 Aug 2022 05:47:26 -0700 [thread overview]
Message-ID: <YvT6XjTWPKfsPbI7@infradead.org> (raw)
In-Reply-To: <166007921743.3294543.7334567013352169774.stgit@magnolia>
Maybe we just simply need to set NEEDSREPAIR for any run that does
not specify the no-modify flag and avoid this magic lazy behavior?
That being said the code looks sane if we can't fix this better by
just working differently.
next prev parent reply other threads:[~2022-08-11 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 21:06 [PATCHSET v2 0/2] xfsprogs: random fixes for 5.19 Darrick J. Wong
2022-08-09 21:06 ` [PATCH 1/2] xfs_repair: fix printf format specifiers on 32-bit platforms Darrick J. Wong
2022-08-11 12:37 ` Christoph Hellwig
2022-08-09 21:06 ` [PATCH 2/2] xfs_repair: retain superblock buffer to avoid write hook deadlock Darrick J. Wong
2022-08-11 12:47 ` Christoph Hellwig [this message]
2022-08-11 18:46 ` Darrick J. Wong
2022-08-11 22:15 ` Dave Chinner
2022-08-16 2:12 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvT6XjTWPKfsPbI7@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.