From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, alexanderduyck@fb.com,
edumazet@google.com
Subject: Re: [PATCH nf 0/4] netfilter: conntrack: remove 64kb max size assumptions
Date: Thu, 11 Aug 2022 16:41:43 +0200 [thread overview]
Message-ID: <YvUVJwW4QhCVcHik@salvia> (raw)
In-Reply-To: <20220809131635.3376-1-fw@strlen.de>
On Tue, Aug 09, 2022 at 03:16:31PM +0200, Florian Westphal wrote:
> Some of our dated conntrack helpers assume skbs can't contain
> tcp packets larger than 64kb.
>
> Update those. For SANE, I don't see a reason for the
> 'full-packet-copy', just extract the sane header.
>
> For h323, packet gets capped at 64k; larger one will be
> seen as truncated.
>
> For irc, cap at 4k: a line length should not exceed 512 bytes.
> For ftp, use skb_linearize(), its the most simple way to resolve this.
Applied, thanks.
prev parent reply other threads:[~2022-08-11 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 13:16 [PATCH nf 0/4] netfilter: conntrack: remove 64kb max size assumptions Florian Westphal
2022-08-09 13:16 ` [PATCH nf 1/4] netfilter: conntrack: sane: remove pseudo skb linearization Florian Westphal
2022-08-09 13:16 ` [PATCH nf 2/4] netfilter: conntrack: h323: cap packet size at 64k Florian Westphal
2022-08-09 13:16 ` [PATCH nf 3/4] netfilter: conntrack_ftp: prefer skb_linearize Florian Westphal
2022-08-09 15:36 ` Alexander Duyck
2022-08-09 16:07 ` Florian Westphal
2022-08-09 16:54 ` Alexander Duyck
2022-08-09 22:38 ` Florian Westphal
2022-08-09 13:16 ` [PATCH nf 4/4] netfilter: conntrack_irc: cap packet search space to 4k Florian Westphal
2022-08-11 14:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvUVJwW4QhCVcHik@salvia \
--to=pablo@netfilter.org \
--cc=alexanderduyck@fb.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.