From: William McVicker <willmcvicker@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
kernel-team@android.com, "Vidya Sagar" <vidyas@nvidia.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] PCI: dwc: add support for 64-bit MSI target address
Date: Thu, 11 Aug 2022 16:36:04 +0000 [thread overview]
Message-ID: <YvUv9Pt5PiLPAuTu@google.com> (raw)
In-Reply-To: <YvTKTCABejYZERnh@infradead.org>
On 08/11/2022, Christoph Hellwig wrote:
> On Tue, Aug 09, 2022 at 06:00:50PM +0000, Will McVicker wrote:
> > + bool msi_64b = false;
>
> Spellt out bit here?
>
> > + msi_capabilities = dw_pcie_msi_capabilities(pci);
> > + if (msi_capabilities & PCI_MSI_FLAGS_ENABLE)
> > + msi_64b = msi_capabilities & PCI_MSI_FLAGS_64BIT ? true : false;
>
> No need for the tenary operator here:
>
> msi_64bit = msi_capabilities & PCI_MSI_FLAGS_64BIT;
Thanks for the suggestions. I'll update in the next patchset.
next prev parent reply other threads:[~2022-08-11 17:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 18:00 [PATCH v1 0/2] PCI: dwc: Add support for 64-bit MSI target addresses Will McVicker
2022-08-09 18:00 ` [PATCH v1 1/2] PCI: dwc: drop dependency on ZONE_DMA32 Will McVicker
2022-08-11 9:20 ` Christoph Hellwig
2022-08-11 16:38 ` William McVicker
2022-08-09 18:00 ` [PATCH v1 2/2] PCI: dwc: add support for 64-bit MSI target address Will McVicker
2022-08-10 17:18 ` kernel test robot
2022-08-11 9:22 ` Christoph Hellwig
2022-08-11 16:36 ` William McVicker [this message]
2022-08-11 12:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvUv9Pt5PiLPAuTu@google.com \
--to=willmcvicker@google.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hch@infradead.org \
--cc=jingoohan1@gmail.com \
--cc=kernel-team@android.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.