From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF7AAC19F2A for ; Thu, 11 Aug 2022 22:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234269AbiHKWZl (ORCPT ); Thu, 11 Aug 2022 18:25:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234106AbiHKWZk (ORCPT ); Thu, 11 Aug 2022 18:25:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C63FD90C79; Thu, 11 Aug 2022 15:25:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 235516153E; Thu, 11 Aug 2022 22:25:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3928EC433D6; Thu, 11 Aug 2022 22:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660256738; bh=Ju5fw6M4oF7Kaa6Ojd7ycLcKYwPg9N5EWmJlDUgLLYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j+yLRJDgrq2OPVuDKo41fFXEwx/yrwkjyCPnh1GM16+Aq8llcjOYjexEbC1IBw+RI rKYZQ+Rh49gpCWt/BYC8WqfbNmLQjZRwHqUNAPR5T0Wcru8rNsPQkdjGMs4IIH/wYZ Cn4x35fAswbCXuz+YwJ6UyppE9stwdnHVftuso3B4/ZkNEkNIMT8PZaWanML0175b7 X6wXYtOpUQRZCNiW3ZIl7q7SfWhmzwwpVTPZg7YaNqA4GpPTa/G3Lnuw2oiFJpPuMw MwLrcfRlAtBfME9YlCejK7St3I3YTV0pm+cZrdKiNCqfg0KOWJ12WVdsBR/rATi7qf nxMlBJd37w11Q== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D1FE94035A; Thu, 11 Aug 2022 19:25:35 -0300 (-03) Date: Thu, 11 Aug 2022 19:25:35 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , James Clark , Mike Leach , Kajol Jain , Ali Saidi , Adrian Hunter , "Gustavo A. R. Silva" , Anshuman Khandual , Ian Rogers , Like Xu , German Gomez , Timothy Hayes , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 00/15] perf c2c: Support data source and display for Arm64 Message-ID: References: <20220811062451.435810-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220811062451.435810-1-leo.yan@linaro.org> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Thu, Aug 11, 2022 at 02:24:36PM +0800, Leo Yan escreveu: > Arm64 Neoverse CPUs supports data source in Arm SPE trace, this allows > us to detect cache line contention and transfers. > > This patch set has been rebased on the acme/perf/core branch with the latest > commit b39c9e1b101d ("perf machine: Fix missing free of > machine->kallsyms_filename"). > > To make building success, a compilation fixing commit [1] has been sent > to LKML, this patch set is dependent on it. This patch set has been verified > for both x86 perf memory events and Arm SPE events. > > [1] https://lore.kernel.org/lkml/20220811044341.426796-1-leo.yan@linaro.org/ So, I tentatively applied this set after applying the patch for , and its all now out in tmp.perf/core in my git tree, please check. I'm doing the usual set of container build tests, but any additional checking, including on the committer note I added to the first patch in this series, claryfing it is not really a "sync" with the kernel headers, is more than welcome. - Arnaldo > Changes from v5: > * Removed the patch "perf: Add SNOOP_PEER flag to perf mem data struct" > (Arnaldo); > * Removed the patch "perf arm-spe: Don't set data source if it's not a > memory operation" which has been merged in the mainline kernel, so can > dismiss merging conflict. > * Rebased on the latest acme perf/core branch, no any code change > compared to previous version. > > Changes from v4: > * Included Ali's patch set for adding data source in Arm SPE samples; > * Added Ian's ACK and Ali's review and test tags; > * Update document for the default peer dispaly for Arm64 (Ali). > > Changes from v3: > * Changed to display remote and local peer accesses (Joe); > * Fixed the usage info for display types (Joe); > * Do not display HITM dimensions when use 'peer' display, and HITM > display doesn't show any 'peer' dimensions (James); > * Split to smaller patches for adding dimensions of peer operations; > * Updated documentation to reflect the latest GUI and stdio. > > > Ali Saidi (2): > perf tools: sync addition of PERF_MEM_SNOOPX_PEER > perf arm-spe: Use SPE data source for neoverse cores > > Leo Yan (13): > perf mem: Print snoop peer flag > perf mem: Add statistics for peer snooping > perf c2c: Output statistics for peer snooping > perf c2c: Add dimensions for peer load operations > perf c2c: Add dimensions of peer metrics for cache line view > perf c2c: Add mean dimensions for peer operations > perf c2c: Use explicit names for display macros > perf c2c: Rename dimension from 'percent_hitm' to > 'percent_costly_snoop' > perf c2c: Refactor node header > perf c2c: Refactor display string > perf c2c: Sort on peer snooping for load operations > perf c2c: Use 'peer' as default display for Arm64 > perf c2c: Update documentation for new display option 'peer' > > tools/include/uapi/linux/perf_event.h | 2 +- > tools/perf/Documentation/perf-c2c.txt | 31 +- > tools/perf/builtin-c2c.c | 454 ++++++++++++++---- > .../util/arm-spe-decoder/arm-spe-decoder.c | 1 + > .../util/arm-spe-decoder/arm-spe-decoder.h | 12 + > tools/perf/util/arm-spe.c | 130 ++++- > tools/perf/util/mem-events.c | 46 +- > tools/perf/util/mem-events.h | 3 + > 8 files changed, 547 insertions(+), 132 deletions(-) > > -- > 2.34.1 -- - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8283AC19F2A for ; Thu, 11 Aug 2022 22:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ga0L8o8RMWb7h7HtuKgZLu8aWnOnz4C2U64H/Z377uc=; b=10vY2SPYKXZi/Y xuhkHThzIoRcCMyZNshS1OtkiA1FRD3pSK8yjGYOf1fUZ4v4PDgyyuUMAk/UwrbrK/HpIINzT45Fu UFkzB54mrWJGllGmBHQPkxYG5YCJJlM+srcBrBhIdRS8ieyMB+iomPtu9Ias4KS4dGnDPCRMt2oNb IlxHLEE2tmwZe5zOjS9+K8pXepI8cXph4o+LWX6kdVXe5d4aIwov6gGp7APpmEvXXYc5v89Wl/FVF yeY/Dhgbm6UGdS0yFd7OfkcZYiwpaCEQrmzO/82qsQGoq5/Q8G/3w2YOcRomAQqyWtirlbFsPyWOi ZoncNA8wR/VRE7EQ0dcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMGca-0066wI-6m; Thu, 11 Aug 2022 22:25:44 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMGcX-0066v2-N7 for linux-arm-kernel@bombadil.infradead.org; Thu, 11 Aug 2022 22:25:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d9Wsamutuq1x/6m7Q5YlMdqIZKlQmvN1DScxk5Fm1g8=; b=QgtWM1nnjYbn2O4akW/lD+5i7f 0MME+kh1nE/5asvU7QkVsMrk3lB8oIPg8HFKwEiq0g58wR+baUMCo4r7YM51mW6NUq7iNfmhr4PSj zL1jROrTW+k9lQSyoZUo9HOQcUdt8giSk5vB4bgqgmoEqcvs/84GkHM8BVjDqkid9z3zw0o56KjLU 0/zJ4wMhxlxzZx+W8Yo6yrJM5uJ+gVY/yhrn9e0K3GRL688jHxOJSbo58Zb5mCzLCmQPkswqMMGOi NpPwbvjigdmsqyBPdK5th9dOd+gM45Y7mctuDwAg4fo8RzE6zTu6Zl8NuWCq0kp/ThwOhD7LdDGCI GOD2hjvA==; Received: from [187.19.239.32] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMGcW-001LsI-1Z; Thu, 11 Aug 2022 22:25:40 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D1FE94035A; Thu, 11 Aug 2022 19:25:35 -0300 (-03) Date: Thu, 11 Aug 2022 19:25:35 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , James Clark , Mike Leach , Kajol Jain , Ali Saidi , Adrian Hunter , "Gustavo A. R. Silva" , Anshuman Khandual , Ian Rogers , Like Xu , German Gomez , Timothy Hayes , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 00/15] perf c2c: Support data source and display for Arm64 Message-ID: References: <20220811062451.435810-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220811062451.435810-1-leo.yan@linaro.org> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Thu, Aug 11, 2022 at 02:24:36PM +0800, Leo Yan escreveu: > Arm64 Neoverse CPUs supports data source in Arm SPE trace, this allows > us to detect cache line contention and transfers. > > This patch set has been rebased on the acme/perf/core branch with the latest > commit b39c9e1b101d ("perf machine: Fix missing free of > machine->kallsyms_filename"). > > To make building success, a compilation fixing commit [1] has been sent > to LKML, this patch set is dependent on it. This patch set has been verified > for both x86 perf memory events and Arm SPE events. > > [1] https://lore.kernel.org/lkml/20220811044341.426796-1-leo.yan@linaro.org/ So, I tentatively applied this set after applying the patch for , and its all now out in tmp.perf/core in my git tree, please check. I'm doing the usual set of container build tests, but any additional checking, including on the committer note I added to the first patch in this series, claryfing it is not really a "sync" with the kernel headers, is more than welcome. - Arnaldo > Changes from v5: > * Removed the patch "perf: Add SNOOP_PEER flag to perf mem data struct" > (Arnaldo); > * Removed the patch "perf arm-spe: Don't set data source if it's not a > memory operation" which has been merged in the mainline kernel, so can > dismiss merging conflict. > * Rebased on the latest acme perf/core branch, no any code change > compared to previous version. > > Changes from v4: > * Included Ali's patch set for adding data source in Arm SPE samples; > * Added Ian's ACK and Ali's review and test tags; > * Update document for the default peer dispaly for Arm64 (Ali). > > Changes from v3: > * Changed to display remote and local peer accesses (Joe); > * Fixed the usage info for display types (Joe); > * Do not display HITM dimensions when use 'peer' display, and HITM > display doesn't show any 'peer' dimensions (James); > * Split to smaller patches for adding dimensions of peer operations; > * Updated documentation to reflect the latest GUI and stdio. > > > Ali Saidi (2): > perf tools: sync addition of PERF_MEM_SNOOPX_PEER > perf arm-spe: Use SPE data source for neoverse cores > > Leo Yan (13): > perf mem: Print snoop peer flag > perf mem: Add statistics for peer snooping > perf c2c: Output statistics for peer snooping > perf c2c: Add dimensions for peer load operations > perf c2c: Add dimensions of peer metrics for cache line view > perf c2c: Add mean dimensions for peer operations > perf c2c: Use explicit names for display macros > perf c2c: Rename dimension from 'percent_hitm' to > 'percent_costly_snoop' > perf c2c: Refactor node header > perf c2c: Refactor display string > perf c2c: Sort on peer snooping for load operations > perf c2c: Use 'peer' as default display for Arm64 > perf c2c: Update documentation for new display option 'peer' > > tools/include/uapi/linux/perf_event.h | 2 +- > tools/perf/Documentation/perf-c2c.txt | 31 +- > tools/perf/builtin-c2c.c | 454 ++++++++++++++---- > .../util/arm-spe-decoder/arm-spe-decoder.c | 1 + > .../util/arm-spe-decoder/arm-spe-decoder.h | 12 + > tools/perf/util/arm-spe.c | 130 ++++- > tools/perf/util/mem-events.c | 46 +- > tools/perf/util/mem-events.h | 3 + > 8 files changed, 547 insertions(+), 132 deletions(-) > > -- > 2.34.1 -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel