From: Jason Gunthorpe <jgg@nvidia.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Peter Xu <peterx@redhat.com>, Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
John Hubbard <jhubbard@nvidia.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] sched/all: Change BUG_ON() instances to WARN_ON()
Date: Thu, 11 Aug 2022 20:22:54 -0300 [thread overview]
Message-ID: <YvWPThSv65hwuSMl@nvidia.com> (raw)
In-Reply-To: <YvV0e7UY5yRbHNJQ@casper.infradead.org>
On Thu, Aug 11, 2022 at 10:28:27PM +0100, Matthew Wilcox wrote:
> On Thu, Aug 11, 2022 at 01:43:09PM -0700, Linus Torvalds wrote:
> > May I suggest going one step further, and making these WARN_ON_ONCE() instead.
> >
> > >From personal experience, once some scheduler bug (or task struct
> > corruption) happens, ti often *keeps* happening, and the logs just
> > fill up with more and more data, to the point where you lose sight of
> > the original report (and the machine can even get unusable just from
> > the logging).
>
> I've been thinking about magically turning all the WARN_ON_ONCE() into
> (effectively) WARN_ON_RATELIMIT(). I had some patches in that direction
> a while ago but never got round to tidying them up for submission.
I often wonder if we have a justification for WARN_ON to even exist, I
see a lot of pressure to make things into WARN_ON_ONCE based on the
logic that spamming makes it useless..
Maybe a global limit of 10 warn ons per minute or something would be
interesting?
Jason
next prev parent reply other threads:[~2022-08-11 23:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 7:32 [PATCH v1] mm/gup: fix FOLL_FORCE COW security issue and remove FOLL_COW David Hildenbrand
2022-08-08 16:02 ` David Hildenbrand
2022-08-09 18:27 ` Linus Torvalds
2022-08-09 18:45 ` David Hildenbrand
2022-08-09 18:59 ` Linus Torvalds
2022-08-09 19:07 ` Jason Gunthorpe
2022-08-09 19:21 ` Linus Torvalds
2022-08-09 21:16 ` David Laight
2022-08-11 7:13 ` [PATCH] sched/all: Change BUG_ON() instances to WARN_ON() Ingo Molnar
2022-08-11 20:43 ` Linus Torvalds
2022-08-11 21:28 ` Matthew Wilcox
2022-08-11 23:22 ` Jason Gunthorpe [this message]
2022-08-14 1:10 ` John Hubbard
2022-08-12 9:29 ` [PATCH v2] sched/all: Change all BUG_ON() instances in the scheduler to WARN_ON_ONCE() Ingo Molnar
2022-08-15 14:41 ` Mel Gorman
2022-08-15 22:12 ` John Hubbard
2022-08-16 9:40 ` Mel Gorman
2022-08-21 11:28 ` Ingo Molnar
2022-08-22 8:40 ` Mel Gorman
2022-08-12 9:57 ` [tip: sched/urgent] " tip-bot2 for Ingo Molnar
2022-08-09 18:40 ` [PATCH v1] mm/gup: fix FOLL_FORCE COW security issue and remove FOLL_COW Linus Torvalds
2022-08-09 18:48 ` Jason Gunthorpe
2022-08-09 18:53 ` David Hildenbrand
2022-08-09 19:07 ` Linus Torvalds
2022-08-09 19:20 ` David Hildenbrand
2022-08-09 18:48 ` Linus Torvalds
2022-08-09 19:09 ` David Hildenbrand
2022-08-09 20:00 ` Linus Torvalds
2022-08-09 20:06 ` David Hildenbrand
2022-08-09 20:07 ` David Hildenbrand
2022-08-09 20:14 ` Linus Torvalds
2022-08-09 20:20 ` David Hildenbrand
2022-08-09 20:30 ` Linus Torvalds
2022-08-09 20:38 ` Linus Torvalds
2022-08-09 20:42 ` David Hildenbrand
2022-08-09 20:20 ` Linus Torvalds
2022-08-09 20:23 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvWPThSv65hwuSMl@nvidia.com \
--to=jgg@nvidia.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=jhubbard@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=vincent.guittot@linaro.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.